Repository navigation
[Fix] Make the Solar model constructible and runnable - #41810
Merged
Merged
Conversation
This was referenced Sep 30, 2026
ch-wan
force-pushed
the
cheng/hot-fix/prefill-delayer-cp-gather
branch
from
September 30, 2026 04:24
54c6abe to
defe8e8
Compare
ch-wan
requested review from
BBuf,
Edwardf0t1,
FlamingoPg,
Qiaolin-Yu,
Ying1123,
alexnails,
alphabetc1,
hanming-lu,
hnyls2002,
huangtingwei9988,
hzh0425,
ispobock,
liusy58,
merrymercy,
xiezhq-hermann and
yizhang2077
as code owners
September 30, 2026 04:24
ch-wan
requested review from
Alisehen,
AniZpZ,
HaiShaw,
OrangeRedeng,
b8zhong and
mmangkad
as code owners
September 30, 2026 04:24
ch-wan
force-pushed
the
cheng/hot-fix/solar-model-construction
branch
from
September 30, 2026 04:24
3280536 to
4f20ec7
Compare
ch-wan
force-pushed
the
cheng/hot-fix/prefill-delayer-cp-gather
branch
from
September 30, 2026 05:05
defe8e8 to
3284778
Compare
ch-wan
force-pushed
the
cheng/hot-fix/solar-model-construction
branch
from
September 30, 2026 05:05
4f20ec7 to
117af72
Compare
ch-wan
force-pushed
the
cheng/hot-fix/prefill-delayer-cp-gather
branch
from
September 30, 2026 20:26
3284778 to
2ea8e58
Compare
Base automatically changed from
cheng/hot-fix/prefill-delayer-cp-gather
to
main
September 30, 2026 20:26
`SolarForCausalLM` could not be built or run: - `SolarModel` called `make_layers` without the pipeline position, in which case it returns only the layer list, and unpacked the result as `(start_layer, end_layer, layers)`; - the forward passes called `self.pp_group()`, which is a group rather than a function, and the causal-LM forward dropped `pp_proxy_tensors`, so a later pipeline stage would never receive the previous stage's hidden states; - the logits processor was built and called with another framework's signature, `LogitsProcessor(vocab_size, org_vocab_size, logit_scale)` and `(lm_head, hidden_states, forward_batch)`. Build the layers of this pipeline stage, read `self.pp_group` as an attribute, pass `pp_proxy_tensors` through, and build and call the logits processor the way other models do, with the LM head on the attention-TP group under `--enable-dp-lm-head` as the processor expects. The backbone skip connections mix hidden states saved at an earlier layer into a later one, so a pipeline split that puts the two on different stages is now rejected, naming the layer.
ch-wan
force-pushed
the
cheng/hot-fix/solar-model-construction
branch
from
September 30, 2026 20:26
117af72 to
15cf773
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of a stack (oldest at bottom):
Motivation
SolarForCausalLMcannot be built or run:SolarModelcallsmake_layerswithout the pipeline position. In that casemake_layersreturns only the layer list, which is then unpacked as(start_layer, end_layer, layers), so construction fails withtoo many values to unpack.self.pp_group(), which is a group rather than a function. The causal-LM forward also dropspp_proxy_tensors, so a later pipeline stage would never receive the previous stage's hidden states.LogitsProcessor(vocab_size, org_vocab_size, logit_scale)and(lm_head, hidden_states, forward_batch).Modifications
self.pp_groupas an attribute.pp_proxy_tensorsthroughSolarForCausalLM.forward.--enable-dp-lm-head, the LM head sits on the attention-TP group, as the processor expects.test_solar_pipeline_split.pychecks this against the checkpoint's skip layout: PP 1 and 2 are accepted, PP 4 is rejected.Accuracy Tests
H200,
upstage/solar-pro-preview-instruct(--trust-remote-code), GSM8K 200 questions:main--tp-size 2--tp-size 2 --pp-size 2--pp-size 4test/registered/unitat this PR's head, compared withmain: no new failures.Speed Tests and Profiling
Not applicable.
Checklist
Review and Merge Process
/tag-and-rerun-ci,/tag-run-ci-label,/rerun-failed-ciCI States
Latest PR Test (Base): 🚫 Run #36772646799
Latest PR Test (Extra): 🚫 Run #36772646360
Latest PR Test (AMD ROCm 10): ❌ Run #36772646960