Skip to content

[Fix] Pass the draft's attention ownership to DFLASH's eager LiLiCorr scope - #41808

Merged
ch-wan merged 1 commit into
mainfrom
cheng/hot-fix/dflash-lilicorr-draft-scope
Sep 30, 2026
Merged

ch-wan merged 1 commit into
mainfrom
cheng/hot-fix/dflash-lilicorr-draft-scope

Conversation

@ch-wan

@ch-wan ch-wan commented Sep 30, 2026 •

Copy link
Copy Markdown
Collaborator

This PR is part of a stack (oldest at bottom):

Motivation

The eager LiLiCorr proposal enters self.draft_tp_context(tp_group) without owns_attention. Under DP attention that callable is draft_tp_context, whose owns_attention is keyword-only and required, so the eager path raises TypeError.

Modifications

Pass self.draft_owns_attention, as every other draft scope in the worker does.

Later in this stack, draft_tp_context takes only owns_attention, which removes this class of mismatch.

Accuracy Tests

Not run end to end.

test/registered/unit at this PR's head, compared with main: no new failures.

Speed Tests and Profiling

Not applicable.

Checklist

Review and Merge Process

  1. Ping Merge Oncalls to start the process. See the PR Merge Process.
  2. Get approvals from CODEOWNERS and other reviewers.
  3. Trigger CI tests with comments or contact authorized users to do so.
    • Common commands include /tag-and-rerun-ci, /tag-run-ci-label, /rerun-failed-ci
  4. After green CI and required approvals, ask Merge Oncalls or people with Write permission to merge the PR.

CI States

Latest PR Test (Base): 🚫 Run #36772577845
Latest PR Test (Extra): 🚫 Run #36772577309
Latest PR Test (AMD ROCm 10): 🚫 Run #36772577930

@ch-wan
ch-wan force-pushed the cheng/hot-fix/moe-wna16-ep-shard-rank branch from a68cd88 to 3fb1054 Compare September 30, 2026 04:24
@ch-wan
ch-wan force-pushed the cheng/hot-fix/dflash-lilicorr-draft-scope branch from e0a6a7c to e25092f Compare September 30, 2026 04:24
@ch-wan
ch-wan force-pushed the cheng/hot-fix/moe-wna16-ep-shard-rank branch from 3fb1054 to 623f068 Compare September 30, 2026 05:05
@ch-wan
ch-wan force-pushed the cheng/hot-fix/dflash-lilicorr-draft-scope branch from e25092f to 0b5ba8c Compare September 30, 2026 05:05
@ch-wan
ch-wan force-pushed the cheng/hot-fix/moe-wna16-ep-shard-rank branch from 623f068 to dcd6a6b Compare September 30, 2026 20:25
Base automatically changed from cheng/hot-fix/moe-wna16-ep-shard-rank to main September 30, 2026 20:25
The eager LiLiCorr proposal entered `self.draft_tp_context(tp_group)`
without `owns_attention`. Under DP attention that callable is
`draft_tp_context`, whose `owns_attention` is keyword-only and required,
so the eager path raised TypeError. Pass `self.draft_owns_attention`, as
every other scope in the worker does.
@ch-wan
ch-wan force-pushed the cheng/hot-fix/dflash-lilicorr-draft-scope branch from 0b5ba8c to 57f0511 Compare September 30, 2026 20:25
@ch-wan
ch-wan merged commit ecc0f0d into main Sep 30, 2026
@ch-wan
ch-wan deleted the cheng/hot-fix/dflash-lilicorr-draft-scope branch September 30, 2026 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant