Repository navigation
[Fix] Pass the draft's attention ownership to DFLASH's eager LiLiCorr scope - #41808
Merged
Merged
Conversation
ch-wan
requested review from
Qiaolin-Yu,
Ying1123,
hnyls2002 and
merrymercy
as code owners
September 30, 2026 03:07
This was referenced Sep 30, 2026
ch-wan
force-pushed
the
cheng/hot-fix/moe-wna16-ep-shard-rank
branch
from
September 30, 2026 04:24
a68cd88 to
3fb1054
Compare
ch-wan
requested review from
BBuf,
Edwardf0t1,
FlamingoPg,
alexnails,
alphabetc1,
hanming-lu,
huangtingwei9988,
hzh0425,
ispobock,
liusy58,
xiezhq-hermann and
yizhang2077
as code owners
September 30, 2026 04:24
ch-wan
requested review from
Alisehen,
AniZpZ,
HaiShaw,
OrangeRedeng,
b8zhong and
mmangkad
as code owners
September 30, 2026 04:24
ch-wan
force-pushed
the
cheng/hot-fix/dflash-lilicorr-draft-scope
branch
from
September 30, 2026 04:24
e0a6a7c to
e25092f
Compare
ch-wan
force-pushed
the
cheng/hot-fix/moe-wna16-ep-shard-rank
branch
from
September 30, 2026 05:05
3fb1054 to
623f068
Compare
ch-wan
force-pushed
the
cheng/hot-fix/dflash-lilicorr-draft-scope
branch
from
September 30, 2026 05:05
e25092f to
0b5ba8c
Compare
ch-wan
force-pushed
the
cheng/hot-fix/moe-wna16-ep-shard-rank
branch
from
September 30, 2026 20:25
623f068 to
dcd6a6b
Compare
Base automatically changed from
cheng/hot-fix/moe-wna16-ep-shard-rank
to
main
September 30, 2026 20:25
The eager LiLiCorr proposal entered `self.draft_tp_context(tp_group)` without `owns_attention`. Under DP attention that callable is `draft_tp_context`, whose `owns_attention` is keyword-only and required, so the eager path raised TypeError. Pass `self.draft_owns_attention`, as every other scope in the worker does.
ch-wan
force-pushed
the
cheng/hot-fix/dflash-lilicorr-draft-scope
branch
from
September 30, 2026 20:25
0b5ba8c to
57f0511
Compare
This was referenced Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of a stack (oldest at bottom):
Motivation
The eager LiLiCorr proposal enters
self.draft_tp_context(tp_group)withoutowns_attention. Under DP attention that callable isdraft_tp_context, whoseowns_attentionis keyword-only and required, so the eager path raisesTypeError.Modifications
Pass
self.draft_owns_attention, as every other draft scope in the worker does.Later in this stack,
draft_tp_contexttakes onlyowns_attention, which removes this class of mismatch.Accuracy Tests
Not run end to end.
test/registered/unitat this PR's head, compared withmain: no new failures.Speed Tests and Profiling
Not applicable.
Checklist
Review and Merge Process
/tag-and-rerun-ci,/tag-run-ci-label,/rerun-failed-ciCI States
Latest PR Test (Base): 🚫 Run #36772577845
Latest PR Test (Extra): 🚫 Run #36772577309
Latest PR Test (AMD ROCm 10): 🚫 Run #36772577930