Repository navigation
[sgl-router] Release cancelled circuit-breaker probes - #40603
Merged
Merged
Conversation
Kangyan-Zhou
approved these changes
Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cancelling a half-open upstream request left its circuit-breaker probe occupied indefinitely, excluding the worker even after recovery.
Modifications
Use an admission guard that releases its own unfinished probe on cancellation. A generation check prevents old requests from releasing newer probes; streaming completion keeps its existing outcome accounting.
Accuracy Tests
cargo test --workspace --lib --tests --quietpassed, including two focused regressions for probe ownership and cancellation of both forwarding paths.Speed Tests and Profiling
Not applicable; no inference changes.
CI States
Latest PR Test (Base): ✅ Run #35631342757
Latest PR Test (Extra): 🚫 Run #35653348360
Latest PR Test (AMD ROCm 10): ➖ No AMD PR run found for this commit.