Support penalty in overlap mode; return logprob with chunked prefill; improve benchmark scripts #3988
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merrymercy
requested review from
BBuf,
ByronHsu,
HaiShaw,
HandH1998,
Ying1123,
hnyls2002,
ispobock,
yizhang2077 and
zhyncs
as code owners
merrymercy
changed the title
zhyncs
reviewed
Mar 3, 2025
merrymercy
added a commit
that referenced
this pull request
Mar 3, 2025
… improve benchmark scripts (#3988) Co-authored-by: SangBin Cho <[email protected]> Co-authored-by: dhou-xai <[email protected]> Co-authored-by: Hanming Lu <[email protected]>
6 tasks
This was referenced Mar 3, 2025
zhaochenyang20
pushed a commit
that referenced
this pull request
Mar 4, 2025
aoshen524
pushed a commit
to aoshen524/sglang
that referenced
this pull request
Mar 10, 2025
… improve benchmark scripts (sgl-project#3988) Co-authored-by: SangBin Cho <[email protected]> Co-authored-by: dhou-xai <[email protected]> Co-authored-by: Hanming Lu <[email protected]>
aoshen524
pushed a commit
to aoshen524/sglang
that referenced
this pull request
Mar 10, 2025
6 tasks
|
hi @merrymercy , why remove repetition_penalty.py? |
|
@merrymercy I have same question, why remove repetition_penalty.py? for now, how it works when repetition_penalty is set? |
6 tasks
elvischenv
reviewed
Nov 10, 2025
Comment on lines
1068
to
1076
| print("{:<40} {:<10.2f}".format("P99 TTFT (ms):", metrics.p99_ttft_ms)) | ||
| print( | ||
| "{s:{c}^{n}}".format(s="Time per Output Token (excl. 1st token)", n=50, c="-") | ||
| ) | ||
| print("{:<40} {:<10.2f}".format("Mean TPOT (ms):", metrics.mean_tpot_ms)) | ||
| print("{:<40} {:<10.2f}".format("Median TPOT (ms):", metrics.median_tpot_ms)) | ||
| print("{:<40} {:<10.2f}".format("P99 TPOT (ms):", metrics.p99_tpot_ms)) | ||
| print("{s:{c}^{n}}".format(s="Inter-token Latency", n=50, c="-")) | ||
| print("{s:{c}^{n}}".format(s="Inter-Token Latency", n=50, c="-")) | ||
| print("{:<40} {:<10.2f}".format("Mean ITL (ms):", metrics.mean_itl_ms)) |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--skip-tokenizer-init