Skip to content

Conversation

@fzyzcjy
Copy link
Collaborator

@fzyzcjy fzyzcjy commented Mar 25, 2025

Motivation

This causes issue in bench_one_batch_sever.py, where the logic is stopping profile and then quiting. Since the original stop_profile is fire-and-forget instead of waiting-for-finishing, the subprocesses gets killed.

Please subtract diff from #4740

EDIT: possibly related #3988, where start_profile does wait

Modifications

Checklist

@merrymercy
Copy link
Contributor

please fix the conflicts

@fzyzcjy
Copy link
Collaborator Author

fzyzcjy commented Mar 28, 2025

done

@fzyzcjy
Copy link
Collaborator Author

fzyzcjy commented Apr 21, 2025

conflicts resolved

@zhyncs zhyncs requested a review from zhaochenyang20 as a code owner May 18, 2025 00:06
@zhyncs zhyncs merged commit 01d2838 into sgl-project:main May 18, 2025
0 of 37 checks passed
@yizhang2077 yizhang2077 mentioned this pull request May 19, 2025
6 tasks
Layssy pushed a commit to Layssy/sglang-iaas that referenced this pull request Jun 9, 2025
xwu-intel pushed a commit to xwu-intel/sglang that referenced this pull request Jun 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants