Repository navigation
Conversation
nvpohanh
requested review from
Fridge003,
Qiaolin-Yu,
Ying1123,
hnyls2002,
ispobock and
merrymercy
as code owners
September 15, 2026 12:13
Collaborator
Author
|
cc @YAMY1234 |
Collaborator
|
Thanks for the fix. This overlaps almost entirely with #39378 : applying both yields conflicts in validation_hook.py, layer_setup.py and test_server_args.py, and the layer_setup change becomes dead code once #39378 removes the assertion. Suggest closing this PR and adding the four Qwen3_5* architectures to |
This was referenced Sep 15, 2026
YAMY1234
added a commit
to nvpohanh/sglang
that referenced
this pull request
Sep 18, 2026
Fold the Qwen3.5 allowlist from sgl-project#39602 into the shared check_pipeline_parallel_compat gate so disaggregated-prefill PP + MTP works for Qwen3.5 dense/MoE (text and multimodal) alongside DeepSeek/GLM. Also covers the SGLANG_ENABLE_PP_SPEC aggregate branch that main added in sgl-project#30775 and that the merge folded into the same function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[by Codex]
Motivation
Qwen3.5 gained the pipeline-parallel speculative-prefill runtime in #35758, but two older assertions still reject the supported configuration. The published PP4 AgentX recipes therefore have to set
PYTHONOPTIMIZE=1to start.This removes that workaround for the supported path without opening unsupported PP+spec combinations.
Changes
disaggregation-mode=prefill.Related: #39378 handles the corresponding DeepSeek/GLM path independently.
Validation
BLACK_NUM_WORKERS=1 SKIP=no-commit-to-branch pre-commit run --all-files --show-diff-on-failureCI States
Latest PR Test (Base): ❌ Run #34967629389
Latest PR Test (Extra): ❌ Run #34967629188
Latest PR Test (AMD ROCm 10): ❌ Run #34967629495