Skip to content

Fix stale DSV4 indexer metadata names in the TopK v2 dispatch test - #39101

Merged
ch-wan merged 1 commit into
mainfrom
mmangkad/fix-dsv4-topk-v2-test-metadata-names
Sep 11, 2026
Merged

ch-wan merged 1 commit into
mainfrom
mmangkad/fix-dsv4-topk-v2-test-metadata-names

Conversation

@mmangkad

@mmangkad mmangkad commented Sep 11, 2026

Copy link
Copy Markdown
Collaborator

#38947 renamed PagedIndexerMetadata.c4_seq_lens to compressed_seq_lens and turned the derived c4_page_size property into an explicit compressed_page_size field. #33672 landed a new test built on a pre-rename base, so its hand-built metadata stub still sets the old names and forward_c4_indexer blows up on main.

AttributeError: 'PagedIndexerMetadata' object has no attribute 'compressed_seq_lens'. Did you mean: 'max_compressed_seq_len'?
ERROR: test_v2_raw_output_uses_sparse_prefill_buffer_with_capture (__main__.TestDSV4TopKDispatch)
Ran 10 tests in 1.887s
FAILED (errors=1)

After: Ran 10 tests in 0.017s / OK.


CI States

Latest PR Test (Base): ❌ Run #34614847128
Latest PR Test (Extra): ❌ Run #34614847087
Latest PR Test (AMD ROCm 10): ❌ Run #34614847159

@mmangkad

Copy link
Copy Markdown
Collaborator Author

/rerun-test test/registered/unit/layers/test_dsv4_nonpaged_indexer.py

@github-actions

github-actions Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Results for /rerun-test test/registered/unit/layers/test_dsv4_nonpaged_indexer.py:

🚀 ubuntu-latest (1 test): ✅ View workflow run

cd test/ && python3 registered/unit/layers/test_dsv4_nonpaged_indexer.py

@ch-wan
ch-wan merged commit 4309c7c into main Sep 11, 2026
111 of 123 checks passed
@ch-wan
ch-wan deleted the mmangkad/fix-dsv4-topk-v2-test-metadata-names branch September 11, 2026 15:31
mqhc2020 pushed a commit to mqhc2020/sglang that referenced this pull request Sep 15, 2026
…gl-project#39101)

Co-authored-by: Mohammad Angkad <mohammad.angkad@radixark.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants