[Refactor] Clarify DeepSeek V4 metadata names for V4.1 - #38947
Merged
Merged
Conversation
c0_flashmla_metadata
hnyls2002
marked this pull request as ready for review
September 10, 2026 22:22
hnyls2002
requested review from
ByronHsu,
Duyi-Wang,
Fridge003,
HaiShaw,
Qiaolin-Yu,
ShangmingCai,
Ying1123,
alphabetc1,
hanming-lu,
hebiao064,
huangtingwei9988,
hzh0425,
iforgetmyname,
ispobock,
merrymercy,
ping1jing2,
sogalin,
whybeyoung,
xiezhq-hermann and
yizhang2077
as code owners
September 10, 2026 22:22
amd-danli103
added a commit
to amd-danli103/sglang
that referenced
this pull request
Sep 11, 2026
Three textual conflicts: - deepseek_v4_backend_hip_radix.py: upstream (sgl-project#38947) replaced the get_swa_out_cache_loc / get_unified_swa_loc docstrings with one-line comments. This branch had only reworded them, so upstream wins and the reword leaves the diff. - deepseek_v4_memory_pool.py: same PR renamed get_c128_state_buf_infos to get_request_state_buf_infos, which this branch had appended get_swa_state_coupling_infos in front of. Both kept, new name taken; the two call sites merged clean on upstream's side. - swa_component.py: upstream commented the host_lru lookup in redistribute_on_node_split, which this branch had hoisted above the strict ring-page split. Nothing used it in between, so the hoist goes and upstream's placement stands.
mqhc2020
pushed a commit
to mqhc2020/sglang
that referenced
this pull request
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
c0_flashmla_metadataandc0_cnt; paged indexer metadata usescompressed_seq_lens,compressed_page_size, andmax_compressed_seq_len.get_request_state_buf_infosand the Python enum member toStateType.DSV4_REQUEST_STATE, preserving its"c128_state"wire value. Keep C128-specific index calculations and HiCache pool identifiers unchanged.CI States
Latest PR Test (Base): 🚫 Run #34537091029
Latest PR Test (Extra): ❌ Run #34537090862
Latest PR Test (AMD ROCm 10): ❌ Run #34537090927