[AMD][CI] Drop the dead miles ROCm 7.0 nightly image build - #38694
Merged
Merged
Conversation
radixark/miles#2854 removed the rocm700-mi35x and rocm700-mi30x variants from docker/build.py, leaving rocm720-mi35x and rocm10-mi35x. This workflow still asks for the retired variants, so since that merge it can only fail: Invalid value for '--variant': 'rocm700-mi35x' is not one of 'cu13', ... Nothing consumes the miles-rocm700-* tags. The ROCm 10 replacement workflows come from #37495. Co-authored-by: Michael <michaelzhang-ai@users.noreply.github.com>
michaelzhang-ai
marked this pull request as ready for review
September 9, 2026 14:18
michaelzhang-ai
requested review from
Fridge003,
HaiShaw,
Kangyan-Zhou,
bingxche,
ispobock and
merrymercy
as code owners
September 9, 2026 14:19
HaiShaw
approved these changes
Sep 10, 2026
mqhc2020
pushed a commit
to mqhc2020/sglang
that referenced
this pull request
Sep 15, 2026
…ct#38694) Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Michael <michaelzhang-ai@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
release-docker-amd-miles-rocm700-nightly.ymlbuilds therocm700-mi35xandrocm700-mi30xvariants through miles'docker/build.py. radixark/miles#2854 ("retire the rocm700 variants, add a rocm10-mi35x variant") merged 2026-09-09 05:37 UTC and deleted both, leavingrocm720-mi35xandrocm10-mi35xas the only ROCm variants.The workflow still asks for the retired ones, so the very next scheduled run — run 34348795681, 2026-09-09 12:02 UTC — failed immediately:
It cannot succeed again. Left in place it burns two
amd-docker-scalejobs and posts a red daily build on the MILES dashboard every day at 12:00 UTC, which is noise on top of the real nightly failures.Modifications
Delete
.github/workflows/release-docker-amd-miles-rocm700-nightly.yml.The ROCm 10 replacements (
release-docker-amd-miles-rocm10-nightly.ymlandnightly-test-amd-miles-rocm10.yml) are already proposed in #37495, so this only removes the dead half; the two can land in either order.Verification
rg 'miles-rocm700'over the repo returns nothing, so no workflow, script or doc consumes therocm/sgl-dev:miles-rocm700-*tags this workflow published. The remainingrocm700hits inscripts/ci/amd/amd_ci_start_container*.shanddocker/rocm.Dockerfilerefer to plain SGLang ROCm 7.0 images (v0.5.8.post1-rocm700-*), which are unrelated and untouched.rg 'release-docker-amd-miles-rocm700'returns nothing, so nothing references the workflow by name.python3 scripts/lint/check_workflow_job_names.pypasses.['cu13', 'cu13-x86', 'cu13-aarch64', 'cu12-x86', 'rocm720-mi35x', 'rocm10-mi35x'];rocm700no longer appears anywhere in that repo outside docs.release-docker-amd-miles-rocm720-nightly.ymlis unaffected —rocm720-mi35xis still a supported variant and that workflow still builds.Accuracy Tests
Not applicable — removes a CI workflow, no model or kernel code is touched.
Speed Tests and Profiling
Not applicable.
Checklist
CI States
Latest PR Test (Base): ✅ Run #34360497621
Latest PR Test (Extra): ❌ Run #34360497168
Latest PR Test (AMD ROCm 10): ➖ No AMD PR run found for this commit.