[Rust TreeCore] Harden runtime and CI parity - #37303
Conversation
e394052 to
019f203
Compare
|
/rerun-failed-ci 09/01 2:51PM PT: rerun due to tests got cancelled |
|
Thanks for the fix for AMD CI. May I know the plan of supporting Rust TreeCore on AMD? This PR has conflicts now, can I cherry pick first to skip the failed test |
Let me do a quick rebase now. And I could followup to do the supporting in AMD, ideally, it should be pretty lightweight. |
019f203 to
f058a65
Compare
Please feel free to go ahead landing #38287 for unblocking AMD first. I could do the rebase correspondingly later on. |
|
/rerun-failed-ci
|
Thanks! No worry :) |
Resolves the overlap between the RadixValue generics on this branch and the NodeAccessError Result returns plus the two new finalize_match_result_in_tree_core parameters from #37303: every conflicting signature keeps main's shape with V in place of Tensor, try_resolve_node_handle_ callers use arena.resolve, and the torch-free integration tests unwrap the now fallible APIs.
Motivation
The Rust TreeCore still has a few correctness and build-integration gaps after its initial merge:
This PR is rebased onto the merged #37290 crate rename and current
main.Modifications
Rust TreeCore boundary handling
NodeArena::resolvethe single node-handle lookup API and return a dedicatedNodeAccessErrorfor stale handles.KeyErrorwithout poisoning the mutex.buffer_onlysnapshots and the three inspector membership predicates).Rust SWA parity
Rust extension build and CI
torch-sysrebuild inputs.proto/**in Rust extension cache keys, sparse checkout inputs, and cache seeding triggers.Accuracy Tests
No model kernels or numerical computation are changed.
Validation performed on the consolidated branch:
Speed Tests and Profiling
Not applicable. These changes affect error handling, SWA transfer validation, extension cache invalidation, and CI registration; they do not modify model execution or kernel hot paths.
Checklist
Review and Merge Process
/tag-and-rerun-ci,/tag-run-ci-label,/rerun-failed-ci.CI States
Latest PR Test (Base): ✅ Run #34097120801
Latest PR Test (Extra): ✅ Run #34097120429
Latest PR Test (AMD ROCm 7.2): ❌ Run #34097120691