Skip to content

[Rust] Rename mem-cache to sglang-radix-tree - #37290

Merged
merrymercy merged 1 commit into
sgl-project:mainfrom
Jialin:codex/rename-sglang-radix-tree
Sep 1, 2026
Merged

merrymercy merged 1 commit into
sgl-project:mainfrom
Jialin:codex/rename-sglang-radix-tree

Conversation

@Jialin

@Jialin Jialin commented Aug 31, 2026

Copy link
Copy Markdown
Collaborator

Motivation

The Rust TreeCore crate was introduced as mem-cache, which is broader than the implementation it contains and does not follow the naming convention of the other SGLang Rust crates.

Rename it to sglang-radix-tree so its ownership and purpose are explicit before follow-up feature work lands.

Modifications

  • Rename the standalone crate directory from rust/mem-cache to rust/sglang-radix-tree.
  • Rename the Cargo package from mem_cache to sglang-radix-tree.
  • Update Cargo workspace metadata, extension discovery, pre-commit commands, CI build paths, documentation, and the registered native-test entry point.
  • Keep the existing Python and shared-library ABI names unchanged:
    • sglang.srt.mem_cache.rust_tree_core.mem_cache
    • mem_cache_inspection
    • libmem_cache.so

All moved Rust implementation and test sources are byte-identical; this PR changes crate identity and build wiring only.

Accuracy Tests

Not applicable: this PR does not change model execution or radix-tree behavior.

Validation performed:

  • Native Rust suite: 831 passed, 1 ignored.
  • Rust extension discovery suite: 14 passed.
  • Production and inspection extensions built and imported under the existing Python module names.
  • cargo metadata --locked passed for both the standalone crate and root Rust workspace.
  • All moved Rust implementation/test files and the compatibility header were verified byte-for-byte against their pre-rename contents.

Speed Tests and Profiling

Not applicable: no runtime implementation changed, and the generated extension/library ABI remains unchanged.

Checklist

Review and Merge Process

  1. Ping Merge Oncalls to start the process. See the PR Merge Process.
  2. Get approvals from CODEOWNERS and other reviewers.
  3. Trigger CI tests with comments or contact authorized users to do so.
    • Common commands include /tag-and-rerun-ci, /tag-run-ci-label, /rerun-failed-ci
  4. After green CI and required approvals, ask Merge Oncalls or people with Write permission to merge the PR.

CI States

Latest PR Test (Base): ✅ Run #33430010718
Latest PR Test (Extra): ✅ Run #33431372202
Latest PR Test (AMD ROCm 7.2): ❌ Run #33430010739

@Jialin

Jialin commented Aug 31, 2026

Copy link
Copy Markdown
Collaborator Author

/run-failed-ci

@Jialin

Jialin commented Aug 31, 2026

Copy link
Copy Markdown
Collaborator Author

/rerun-failed-ci

  • 08/31 8:18PM: AssertionError: avg_kl_div=0.106299891739351 > threshold=0.1 for Qwen/Qwen3-Next-80B-A3B-Instruct test_input_output_logprobs_match_prefill_cache_hit_helper

@merrymercy
merrymercy merged commit a77283f into sgl-project:main Sep 1, 2026
381 of 460 checks passed
@Jialin
Jialin deleted the codex/rename-sglang-radix-tree branch September 1, 2026 17:13
StevenChenSE pushed a commit to StevenChenSE/sglang that referenced this pull request Sep 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation run-ci run-ci-extra unified-radix-cache

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants