Repository navigation
[diffusion] refactor: scope model-specific API parameters - #35613
Merged
Merged
Conversation
mickqian
requested review from
AgainstEntropy,
BBuf,
HaiShaw,
JustinTong0323,
ping1jing2,
sogalin,
wisclmy0611,
yichiche and
zijiexia
as code owners
August 20, 2026 02:38
Collaborator
Author
|
/tag-run-ci-label |
# Conflicts: # python/sglang/multimodal_gen/test/unit/test_video_api_profiling.py
# Conflicts: # python/sglang/multimodal_gen/configs/sample/longcat_image.py
# Conflicts: # python/sglang/multimodal_gen/configs/sample/cosmos3.py # python/sglang/multimodal_gen/runtime/entrypoints/openai/video_api.py # python/sglang/multimodal_gen/test/unit/test_cosmos3.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Model-specific diffusion controls should not accumulate in the shared OpenAI request or base sampling schemas. The current API also hardcodes Cosmos3, ERNIE-Image, and Ideogram fields in generic endpoints, while documented LTX-2.5 online controls are not forwarded at all.
LongCat-Image additionally needs its missing public cookbook/navigation coverage.
Modifications
Cosmos3SamplingParamslowering.auto_durationanduse_diffusion_decoderonline controls.extra_body, video multipartextra_params, and legacy imageextra_args; root-level fields retain precedence.Accuracy Tests
Not run locally, following the repository-local SGLang-Diffusion development guidance. This refactor does not change model computation or default sampling values.
Speed Tests and Profiling
Not applicable. The changes are request validation/lowering and documentation only.
Checklist
CI States
Latest PR Test (Base): ✅ Run #33151263158
Latest PR Test (Extra): ❌ Run #33151262946
Latest PR Test (AMD ROCm 7.2): ⏳ Run #33151263073