ci: path-gate static ratchet scans in lint - #34867
Draft
JustinTong0323 wants to merge 2 commits into
Draft
JustinTong0323 wants to merge 2 commits into
JustinTong0323 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The lint workflow runs
pre-commit --all-fileson every PR, so thecheck-static-ratchetshook (pass_filenames: false) rescans the wholepython/sglangtree even for PRs that change only docs or CI config. This is PR 2 of the lint follow-up plan, stacked on #34864 (this branch contains its commit; the diff shrinks tolint.ymlalone once that merges).What changed
dorny/paths-filter@v3step with aratchetfilter coveringpython/sglang/**, the ratchet aggregator and every checker module it imports, its test files, and both gate definitions (.pre-commit-config.yaml,.github/workflows/lint.yml).SKIPconditionally: a PR touching none of those paths runs withSKIP=no-commit-to-branch,check-static-ratchets, and the decision is echoed in the log.'false'output skips the check; unclassified events (push, classification failure) keep running it — same semantics as the rust-workspace gate.check-static-ratchetshook definition is untouched, so local pre-commit behavior is unchanged.Verification
.github/workflows/lint.yml, which is in the filter — the lint run on this PR must showSKIP=no-commit-to-branchand the ratchet hook executing. Confirmed: run 31819219123 (10m05s wall) loggedratchet changes: true; SKIP=no-commit-to-branchwithvalidate static runtime ratchetsandblack-jupyterboth Passed.SKIP=no-commit-to-branch,check-static-ratchetsand the hook banner as Skipped (CI duration reported as evidence, not a threshold).true/false/empty outputs;pre-commit run --fileson the changed file passes.CI States
Latest PR Test (Base): ✅ Run #31819219562
Latest PR Test (Extra): ❌ Run #31819219544