[CI] Path-gate Rust workspace tests in lint - #34864
Merged
hnyls2002 merged 1 commit intoAug 15, 2026
Merged
Conversation
JustinTong0323
marked this pull request as ready for review
August 14, 2026 15:51
Collaborator
Author
|
/rerun-failed-ci |
JustinTong0323
requested review from
Fridge003,
HaiShaw,
Kangyan-Zhou,
bingxche,
ispobock and
merrymercy
as code owners
August 14, 2026 15:51
Collaborator
Author
|
/rerun-failed-ci |
1 similar comment
Collaborator
Author
|
/rerun-failed-ci |
This was referenced Aug 14, 2026
hnyls2002
approved these changes
Aug 15, 2026
saturn-acc
pushed a commit
to saturn-acc/sglang
that referenced
this pull request
Aug 16, 2026
Atituiset
pushed a commit
to Atituiset/sglang
that referenced
this pull request
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rust/Cargo workspacecargo test --workspaceonly for those changesThe relevant path set includes
rust/**, the protobuf compiled byrust/sglang-grpc/build.rs, and the lint workflow itself. Changes to the gate therefore exercise the Cargo test path.Motivation
PR #34860 changed only documentation, but its lint job still spent 1m44s in
cargo test --workspaceafter an exact 390 MB Rust cache restore. The tests ran in 0.47s; test-profile compilation accounted for nearly all of the step. Documentation-only and unrelated Python changes cannot affect this workspace.Validation
SKIP=no-commit-to-branch pre-commit run --files .github/workflows/lint.ymlThis PR changes
.github/workflows/lint.yml, so its own lint run is expected to execute the Rust workspace tests. After merge, a docs-only lint run should omit that step.CI evidence
Lint run #31815484567 passed on this PR:
Because this PR changes the gate itself, the Rust workspace tests ran and passed. For an unrelated change, the new filter overhead is less than 1 second and the 1m45s Cargo step is skipped.
CI States
Latest PR Test (Base): ✅ Run #31815485017
Latest PR Test (Extra): 🚫 Run #31816640159