Skip to content

fix: restore VLM nightly regression coverage - #34662

Merged
hnyls2002 merged 6 commits into
sgl-project:mainfrom
mickqian:codex/fix-vlm-nightly-regressions
Aug 13, 2026
Merged

hnyls2002 merged 6 commits into
sgl-project:mainfrom
mickqian:codex/fix-vlm-nightly-regressions

Conversation

@mickqian

@mickqian mickqian commented Aug 13, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • keep single-node CUDA IPC multimodal feature transport opt-in
  • preserve automatic CUDA VMM selection for validated multi-node MNNVL deployments
  • refresh VLM MMMU accuracy and latency baselines for the 1024-token CoT evaluation budget

Root cause

PR #27327 increased the MMMU CoT generation budget from 30 to 1024 tokens, but the latency thresholds still described the old 30-token workload. Nightly results moved to a new stable latency plateau immediately after that change, so the old thresholds no longer measured engine regressions.

Pixtral's score has ranged from 0.33 to 0.37 on the fixed 100-sample suite since that change. A 0.36 floor therefore flakes on normal one- or two-question variation; this PR uses 0.32 as the regression floor.

GLM-4.5V-FP8 also had a separate real regression after single-node CUDA IPC became the default. Its fixed 1 GiB feature pool reduced the GLM nightly KV cache from 25,998 to 14,088 tokens, reducing output throughput from about 687 to 549 tokens/s and increasing latency from about 107 to 131 seconds. The latest run reached 148 seconds. Restoring CPU as the single-node default recovers the KV-cache headroom while keeping CUDA IPC available through --mm-feature-transport=cuda_ipc.

The GLM latency threshold is calibrated to the pre-regression 100-119 second plateau with headroom at 140 seconds, so a 208-second result still fails.

Validation

  • all changed-file pre-commit hooks pass
  • Python byte compilation passes
  • git diff --check passes
  • targeted unit-test collection is blocked on the local macOS environment because its Transformers build lacks transformers.image_processing_backends; Linux/H100 CI is required for runtime validation

CI States

Latest PR Test (Base): ❌ Run #31668017794
Latest PR Test (Extra): ❌ Run #31668017661

@github-actions github-actions Bot added the Multi-modal multi-modal language model label Aug 13, 2026
@mickqian

Copy link
Copy Markdown
Collaborator Author

/tag-run-ci-label

@mickqian
mickqian marked this pull request as ready for review August 13, 2026 03:16
@mickqian

Copy link
Copy Markdown
Collaborator Author

/tag-and-rerun-ci

@mickqian

Copy link
Copy Markdown
Collaborator Author

/rerun-test

@github-actions

Copy link
Copy Markdown
Contributor

⛔ Please specify a test: /rerun-test <file>::<TestClass.test_method>

Examples:

  • /rerun-test test/registered/core/test_srt_endpoint.py::TestSRTEndpoint.test_simple_decode
  • /rerun-test registered/core/test_srt_endpoint.py::TestSRTEndpoint
  • /rerun-test test_srt_endpoint.py
  • /rerun-test test_a.py test_b.py test_c.py (multiple tests)
  • /rerun-test test_*backend*.py (wildcard — reruns every matching file; wrap the pattern in backticks so GitHub keeps the * literal)

@hnyls2002

Copy link
Copy Markdown
Collaborator

/rerun-test test/registered/eval/test_vlms_mmmu_eval.py

@github-actions

github-actions Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Results for /rerun-test test/registered/eval/test_vlms_mmmu_eval.py:

🚀 2-gpu-h100 (1 test): ❌ View workflow run

cd test/ && python3 registered/eval/test_vlms_mmmu_eval.py

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Dispatching /rerun-test test/registered/eval/test_vlms_mmmu_eval.py...

@mickqian mickqian removed the run-ci label Aug 13, 2026
@mickqian

Copy link
Copy Markdown
Collaborator Author

/rerun-test test/registered/eval/test_vlms_mmmu_eval.py

@github-actions

github-actions Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Results for /rerun-test test/registered/eval/test_vlms_mmmu_eval.py:

🚀 2-gpu-h100 (1 test): ❌ View workflow run

cd test/ && python3 registered/eval/test_vlms_mmmu_eval.py

@mickqian

Copy link
Copy Markdown
Collaborator Author

/rerun-test test/registered/eval/test_vlms_mmmu_eval.py

@github-actions

github-actions Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Results for /rerun-test test/registered/eval/test_vlms_mmmu_eval.py:

🚀 2-gpu-h100 (1 test): ✅ View workflow run

cd test/ && python3 registered/eval/test_vlms_mmmu_eval.py

@hnyls2002
hnyls2002 merged commit 69bf601 into sgl-project:main Aug 13, 2026
81 of 96 checks passed
saturn-acc pushed a commit to saturn-acc/sglang that referenced this pull request Aug 16, 2026
chencjcj pushed a commit to chencjcj/sglang that referenced this pull request Aug 17, 2026
hanwlax pushed a commit to hanwlax/sglang that referenced this pull request Aug 28, 2026
jakki-amd pushed a commit to jakki-amd/sglang that referenced this pull request Sep 9, 2026
Atituiset pushed a commit to Atituiset/sglang that referenced this pull request Sep 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Multi-modal multi-modal language model

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants