Fix MMMU VLM eval max_tokens for CoT prompt - #27327
Merged
Merged
Conversation
PR sgl-project#21841 changed the MMMU eval prompt to use Chain-of-Thought instructions ("Think step by step before answering") but kept max_tokens=30, which is too short for models to complete their reasoning before outputting "Answer: X". This caused all VLM models to fail the nightly MMMU accuracy test since April 2. Increase max_tokens from 30 to 1024 to give models enough space to reason and produce the expected answer format.
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
Chronostasys
pushed a commit
to MindLab-Research/sglang
that referenced
this pull request
Aug 24, 2026
jakki-amd
pushed a commit
to jakki-amd/sglang
that referenced
this pull request
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
PR #21841 changed the MMMU eval prompt to use Chain-of-Thought instructions ("Think step by step before answering") but kept
max_tokens=30. This is too short for models to complete their reasoning before outputtingAnswer: X, causing all VLM models to fail the nightly MMMU accuracy test since April 2.Modifications
Increase
max_tokensfrom 30 to 1024 intest/registered/eval/test_vlms_mmmu_eval.py.Verification
Tested on H200 with all models in the nightly VLM MMMU eval:
All models that can launch successfully now pass the accuracy threshold.
CI States
Latest PR Test (Base): ❌ Run #26991456983
Latest PR Test (Extra): ❌ Run #26991456867