[Kernel] Move sgl-kernel under sglang.kernels.aot - #32648
Merged
Merged
Conversation
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
github-actions
Bot
added
documentation
Contributor
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
BBuf
marked this pull request as ready for review
July 28, 2026 11:44
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
BBuf
requested review from
JustinTong0323,
Kangyan-Zhou,
bingxche,
ishandhanani,
sogalin,
wisclmy0611,
yctseng0211 and
zijiexia
as code owners
July 28, 2026 11:44
adityavaid
pushed a commit
to adityavaid/sglang
that referenced
this pull request
Jul 29, 2026
jinzhenfan
pushed a commit
to jinzhenfan/sglang
that referenced
this pull request
Jul 29, 2026
This was referenced Jul 30, 2026
chuyeh
added a commit
to chuyeh/sglang
that referenced
this pull request
Aug 3, 2026
Carry the upstream changes that landed since the last sync into the ROCm 7.2.4 files, which do not inherit them because they are separate copies: - Bump the two rocm724 stages to AITER d9e5ef7, matching the four existing flavors. They were the only stages left on 9127c94. - Regenerate pr-test-amd-rocm724.yml from the current pr-test-amd-rocm720.yml so it picks up the MI325 -> MI300 runner migration (sgl-project#31409), the sgl-kernel move to python/sglang/kernels/aot (sgl-project#32648), and the DSV4 MoE weight-loading env (sgl-project#32315), along with the max-parallel limits and timeout increases that came with them. The MI325 labels and the sgl-kernel test paths were the load-bearing ones: the former no longer resolve to a runner pool, and the latter point at a directory that no longer exists. Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Aug 10, 2026
HanHan009527
added a commit
to bytedance-iaas/sglang
that referenced
this pull request
Aug 14, 2026
The nightly builds deepseek_v4 source but reused ep_main's release-whl-kernel.yml, coupling that shared file to deepseek_v4's directory layout. ep_main follows upstream (kernels under python/sglang/kernels/aot/, per sgl-project#32648) while deepseek_v4 keeps them under sgl-kernel/, so one shared file cannot serve both. Split the two consumers: - Nightly now calls the kernel workflow from the branch it builds: uses: .../release-whl-kernel.yml@bytedance/deepseek_v4 (which now exposes a workflow_call build-wheel job using sgl-kernel/). - ep_main's release-whl-kernel.yml is reverted to python/sglang/kernels/aot, undoing the earlier sgl-kernel path change (31bf244). Its only local consumer, release-docker-dev.yml, builds ep_main source, which uses the upstream python/sglang/kernels/aot/ layout. Each branch's kernel build now tracks its own source structure. Co-authored-by: TRAE CLI <noreply@bytedance.com>
saturn-acc
pushed a commit
to saturn-acc/sglang
that referenced
this pull request
Aug 16, 2026
jakki-amd
pushed a commit
to jakki-amd/sglang
that referenced
this pull request
Sep 9, 2026
Atituiset
pushed a commit
to Atituiset/sglang
that referenced
this pull request
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sgl-kernelsource tree topython/sglang/kernels/aotso SGLang's AOT and JIT kernel implementations live under one kernel namespace.sglang-kernel), Python import (sgl_kernel), operator registrations, versioning, API, and ABI.sglangwheel and sdist, and preserve the previous main/JIT/AOT change-detection boundaries.This is a follow-up to the kernel layout work tracked in #29630.
Validation
pre-commit run --all-filessglang/kernels/aotsgl_kernelpackage and C++/CUDA sourcespython/sglang/kernels/aoton NVIDIA H200sglang-kernel==0.4.5,import sgl_kernel, H200 SM901287 passedacrosstest_activation.py,test_norm.py, andtest_topk.pyCompatibility
Only the repository source location changes. Package names, imports, runtime APIs, operators, and release artifact naming remain unchanged.
CI States
Latest PR Test (Base): 🚫 Run #30367764295
Latest PR Test (Extra): ❌ Run #30367762885