feat: unify multimodal feature transport - #30904
Merged
mickqian merged 3 commits intoJul 15, 2026
Merged
Conversation
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
Collaborator
Author
|
/tag-and-rerun-ci |
mickqian
marked this pull request as ready for review
July 14, 2026 14:39
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
mickqian
requested review from
JustinTong0323,
yhyang201 and
yuan-luo
as code owners
July 14, 2026 14:49
This was referenced Jul 15, 2026
roopaksrivastav
pushed a commit
to roopaksrivastav/sglang
that referenced
this pull request
Jul 16, 2026
Chronostasys
pushed a commit
to MindLab-Research/sglang
that referenced
this pull request
Aug 24, 2026
jakki-amd
pushed a commit
to jakki-amd/sglang
that referenced
this pull request
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--mm-feature-transport={cpu,cuda_ipc}as the single NVIDIA CUDA IPC policy--keep-mm-feature-on-deviceandSGLANG_USE_CUDA_IPC_TRANSPORTto the new policy with deprecation warningsMemory policy
CUDA IPC remains opt-in (
cpuis the default). On H200 TP8 with Kimi-K2.7-Code, the existing 1 GiB pool is allocated immediately on GPU 0; Kimi's largest raw image feature is about 36.75 MiB, so that pool holds about 27 worst-case images. This fixed reservation reduces KV-cache headroom and should not become an unconditional default.Dependency
This PR depends on #30902, which makes
SGLANG_MM_FEATURE_CACHE_MBa hard aggregate budget across tokenizer workers. It should merge first.Validation
py_compilefor modified Python fileshuggingface_hub==1.6.0/@strictincompatibility; CI will run the tests in the pinned environment.CI States
Latest PR Test (Base): ❌ Run #29379619765
Latest PR Test (Extra): ❌ Run #29379619656