Conversation
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
Collaborator
Author
|
closing due to duplication with #31227 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SGLANG_MM_FEATURE_CACHE_MBas a hard per-node CUDA IPC pool budget across tokenizer workersRoot cause
Each tokenizer worker owns a distinct allocation on
base_gpu_id. The previous 128 MiB per-worker floor could make the aggregate reservation larger than the configured budget (for example, a 1 GiB budget with 16 workers reserved 2 GiB).Behavior
The pool now splits the configured budget exactly across workers. A pool miss retains the existing CPU-transport fallback, so SGLang does not allocate additional CUDA memory to preserve IPC.
Validation
PYTHONPATH=$PWD/python uv run python -m pytest test/registered/unit/multimodal/test_cuda_ipc_pool_budget.py -vunittestinvocationCI States
Latest PR Test (Base): ❌ Run #29174721443
Latest PR Test (Extra): ❌ Run #29174721370