[AMD] Cherry-pick AMD fixes into release/v0.5.15 - #30722
Conversation
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
Co-authored-by: sunxxuns <126995791+sunxxuns@users.noreply.github.com> (cherry picked from commit 8d2b66f)
Co-authored-by: zhaolin <zhaolin@amd.com> Co-authored-by: Raiden-Makoto <Raiden-Makoto@users.noreply.github.com> Co-authored-by: HAI <hixiao@gmail.com> (cherry picked from commit 07ef650)
|
@michaelzhang-ai remove #30415 |
f6802b1 to
7302618
Compare
|
@HaiShaw done — #30415 has been removed. I rebased it out and force-pushed, so the PR now contains only the 10 finalized commits (head #30313, #30302, #30374, #29275, #30265, #28534, #30557, #29479, #30339, #29417 #30415 (RDNA3/4 gfx1100/gfx1201) is no longer included, per the finalized list. Note #27436 is also deferred here — it depends on #29742 ("fix z-Image accuracy", not in PTAL when you have a moment — thanks! |
Detail on why #27436 is deferred#27436 (
So cherry-picking #27436 onto release produces a tuple-arity mismatch in the z-image forward path. The #29742 is large — 1067 insertions across 11 files: a new Triton kernel Options for #27436:
|
michaelzhang-ai
left a comment
There was a problem hiding this comment.
Inline notes on the two conflict resolutions in this cherry-pick (for reviewer traceability).
| "MistralLarge3ForCausalLM", | ||
| "PixtralForConditionalGeneration", | ||
| "GlmMoeDsaForCausalLM", | ||
| "GlmMoeDsaForCausalLMNextN", |
There was a problem hiding this comment.
Conflict resolution (#30265): the 3-way merge widened this hunk with upstream LongcatFlash* context lines that are not in release/v0.5.15. I added only what #30265 genuinely introduces — GlmMoeDsaForCausalLMNextN — here (and at the two other arch-list sites, ~L542 draft-model remap and ~L745), and did not pull in the Longcat context.
Verify (where the conflict was) — compare the two diffs (jumps to this file):
- Upstream [AMD] Fix GLM-5.2 MTP Quark excludes #30265 on
main: 07ef650#diff-be7f3f1b02373a39149a134fd553cc61243cbe11d997dc72e319c6123dba4618 - As applied here (on release): 8501969#diff-be7f3f1b02373a39149a134fd553cc61243cbe11d997dc72e319c6123dba4618
| from sglang.srt.models.deepseek_nextn import DeepseekV3ForCausalLMNextN | ||
| from sglang.srt.models.deepseek_v2 import DeepseekV2ForCausalLM | ||
| from sglang.srt.models.utils import apply_qk_norm | ||
| from sglang.srt.models.utils import WeightsMapper, apply_qk_norm |
There was a problem hiding this comment.
Conflict resolution (#30265): import-line clash. Kept release's from sglang.srt.runtime_context import get_flags, get_parallel (get_flags is used in the file body) and merged in only WeightsMapper on this line — it's needed by the new GlmMoeDsaForCausalLMNextN class and is verified present in release models/utils.py. Dropped #30265's get_server_args/get_stream import additions since the cherry-picked code doesn't reference them.
Verify (where the conflict was) — compare the two diffs (jumps to this file):
- Upstream [AMD] Fix GLM-5.2 MTP Quark excludes #30265 on
main: 07ef650#diff-0ccc8d832ece5a51e8d7a0a62b9ba5c056033186e11a0e758f3c11bd5a751106 - As applied here (on release): 8501969#diff-0ccc8d832ece5a51e8d7a0a62b9ba5c056033186e11a0e758f3c11bd5a751106
Upstream (
|
|
@michaelzhang-ai let's remove #28534 too |
7302618 to
4bc3c9c
Compare
|
Update: #28534 ( Why: #28534 was authored on top of #30249 ( Follow-up: revisit #28534 together with #30249 if the ROCm JIT staged HiCache write-back + CPU-index crash fix are wanted in this release line. No other included commit depends on #28534 (verified: #30557/#29479/#30339/#29417 don't touch any of its files), so the drop is clean. |
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
Summary
Cherry-picks the finalized AMD-related PR list from
mainintorelease/v0.5.15. 9 PRs included. Applied in chronological (landing) order, each with-xprovenance.#30237and#30333were verified already present inrelease/v0.5.15.main)dabd4cfcfd349eb8c3c3a15210fd74978335a8129ddea8d9efb3c16bfa35df07681de5c05e5eb04140a68521c9c325cf2757c05e7a476ad4e54f80388d2b66fd9071f29434f5f0a149be1f6829907c2f07ef650ef7b066f8bab81d531acb1edc8231902dbd7e54d7379e437cf5f027382d6ca214e046626b336b64ecce300a3cefc615d84b6780e22f83a89c462b6171bd80902f68a0056c41bf95e0cec914008d0fd341507710d628bf3e05d88ae87253970b78Conflict resolutions (please review)
get_flagsimport, addedWeightsMapper(verified present in releasemodels/utils.py), and added onlyGlmMoeDsaForCausalLMNextNto the arch lists (the upstream Longcat entries were pre-existing context onmain, absent in release, so not introduced).Not included
mem_cache/pool_host/mha.py, which doesn't exist inrelease/v0.5.15. Rather than carry it without [mem_cache][6/N] refactor: move MHA host-pool into pool_host/mha.py #30249, it is deferred; can be revisited together with [mem_cache][6/N] refactor: move MHA host-pool into pool_host/mha.py #30249.33c3dfd7): deferred — depends on [diffusion] Fix Z-Image accuracy #29742 ("fix z-Image accuracy", not in release); release'spatchify_and_embed()returns a 5-tuple while [diffusion] Enable breakable CUDA graph (BCG) for diffusion DiTs #27436 expects the 7->8-tuple form, so it can't be cherry-picked cleanly on its own.Test plan
release/v0.5.15(pr-test-amd) greenNote: blocked/pending #24651 per the release coordination thread.
CI States
Latest PR Test (Base): ❌ Run #29067430598
Latest PR Test (Extra): ❌ Run #29067430426