Repository navigation
[AMD] Enable mamba-extra-buffer for Qwen3.5 on ROCm - #30359
Merged
Merged
Conversation
Contributor
|
Warning Gemini encountered an error creating the review. You can try again by commenting |
This was referenced Jul 7, 2026
1 of 3 tasks
bingxche
changed the title
yctseng0211
marked this pull request as ready for review
July 15, 2026 08:30
Collaborator
result verified |
bingxche
changed the title
4 of 5 tasks
yctseng0211
approved these changes
Jul 15, 2026
HaiShaw
approved these changes
Jul 15, 2026
4 tasks done
ColinZ22
added a commit
to ColinZ22/sglang
that referenced
this pull request
Jul 15, 2026
Revert the is_cuda/is_musa/is_npu guard in _mamba_radix_cache_resolution. main already enables extra_buffer on ROCm via is_hip() (sgl-project#30359); this gate contradicted that and broke test_model_overrides. Co-Authored-By: Claude <noreply@anthropic.com>
Chronostasys
pushed a commit
to MindLab-Research/sglang
that referenced
this pull request
Aug 24, 2026
Co-authored-by: ntgiang71096 <nguyentruonggiang71096@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mamba-extra-bufferon ROCm by acceptingis_hip()in theextra_bufferplatform guard.Qwen/Qwen3.5-397B-A17Bnightly test in AMD Nightly CITesting
CI States
Latest PR Test (Base): ❌ Run #28848756832
Latest PR Test (Extra): ❌ Run #28848756410