[CI] Remove orphaned test/srt/ascend and test/srt/configs#24145
Merged
Conversation
- test/srt/configs/*.yaml were left behind when experiment_runner.py and its workflow were deleted. - test/srt/ascend/test_embed_interpolate_unittest.py was only listed under __not_in_ci__ in the legacy test/srt/run_suite.py and never ran in CI. NPU tests now live in test/registered/ascend/. - Update pr-test-npu.yml change-detection path from test/srt/ascend/** to test/registered/ascend/** to match where NPU tests actually live.
merrymercy
requested review from
Fridge003,
Kangyan-Zhou,
bingxche,
iforgetmyname,
ispobock and
ping1jing2
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the test_embed_interpolate_unittest.py test file and several benchmark configuration files for DeepSeek-V3 and Llama-3.1 models. It also updates test/srt/run_suite.py to remove the reference to the deleted test file from the __not_in_ci__ suite. I have no feedback to provide.
Contributor
Author
|
/tag-and-rerun-ci |
5 tasks
vguduruTT
pushed a commit
to vguduruTT/sglang
that referenced
this pull request
May 2, 2026
LucQueen
pushed a commit
to LucQueen/sglang
that referenced
this pull request
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test/srt/ascend/— the test file was only listed under__not_in_ci__in the legacytest/srt/run_suite.pyand was never run in CI. NPU tests now live intest/registered/ascend/.test/srt/configs/— these YAML configs were left behind whenexperiment_runner.pyand its workflow were deleted.pr-test-npu.ymlchange-detection path fromtest/srt/ascend/**totest/registered/ascend/**so that changes to NPU tests correctly trigger the CI workflow.Test plan
pr-test-npu.ymltriggers correctly on changes totest/registered/ascend/