Skip to content

[NPU] Add GitHub test summary and deduplicate test code. Part 1#23835

Merged
sglang-npu-bot merged 9 commits into
sgl-project:mainfrom
e-martirosian:npu_test_summary
May 2, 2026
Merged

[NPU] Add GitHub test summary and deduplicate test code. Part 1#23835
sglang-npu-bot merged 9 commits into
sgl-project:mainfrom
e-martirosian:npu_test_summary

Conversation

@e-martirosian
Copy link
Copy Markdown
Contributor

@e-martirosian e-martirosian commented Apr 27, 2026 •
edited
Loading

Motivation

It is necessary to add a GitHub summary to present test data and results in a more readable format. Also, the test code needs to be cleaned up — specifically, duplicates should be removed.

Modifications

  • Added summary for tests (gsm8k and mmmu)
  • Remove code duplications

Result

image

Checklist

Review and Merge Process

  1. Ping Merge Oncalls to start the process. See the PR Merge Process.
  2. Get approvals from CODEOWNERS and other reviewers.
  3. Trigger CI tests with comments or contact authorized users to do so.
    • Common commands include /tag-and-rerun-ci, /tag-run-ci-label, /rerun-failed-ci
  4. After green CI and required approvals, ask Merge Oncalls or people with Write permission to merge the PR.

@github-actions github-actions Bot added Multi-modal multi-modal language model deepseek npu labels Apr 27, 2026
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Apr 27, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors Ascend-based tests by introducing the GSM8KAscendMixin and TestMMLU classes to standardize server setup, environment configuration, and evaluation logic. It also implements a reporting utility to write test results directly to the GitHub step summary. The review identifies critical logic errors in the reporting function—specifically regarding incorrect dictionary keys and potential type errors during metric comparisons—as well as a missing import in the piecewise graph prefill test.

Comment thread python/sglang/test/ascend/test_ascend_utils.py Outdated
Comment thread test/registered/ascend/basic_function/optimization_debug/test_npu_piecewise_graph_prefill.py
Comment thread python/sglang/test/ascend/test_ascend_utils.py Outdated
@e-martirosian e-martirosian changed the title [NPU] Add GitHub test summary and deduplicate test code [NPU] Add GitHub test summary and deduplicate test code. Part 1 Apr 27, 2026
@e-martirosian e-martirosian marked this pull request as ready for review April 27, 2026 14:40
@ping1jing2 ping1jing2 self-assigned this Apr 27, 2026
ping1jing2
ping1jing2 reviewed Apr 27, 2026
View reviewed changes
Comment thread test/registered/ascend/basic_function/dllm/test_npu_llada2_mini.py Outdated
@ping1jing2
Copy link
Copy Markdown
Collaborator

ping1jing2 commented Apr 27, 2026

please post your command and summary result here

@ping1jing2
Copy link
Copy Markdown
Collaborator

ping1jing2 commented Apr 27, 2026

/tag-and-rerun-ci

@ping1jing2
Copy link
Copy Markdown
Collaborator

ping1jing2 commented Apr 30, 2026

please fix the confict issues and pay attention to the #24145

@e-martirosian
Copy link
Copy Markdown
Contributor Author

e-martirosian commented Apr 30, 2026

please fix the confict issues and pay attention to the #24145

It conflicts with the changes - #21062.

They removed "SGLANG_ENABLE_SPEC_V2 = 1" because they started to use spec v2 by default.

@ping1jing2
Copy link
Copy Markdown
Collaborator

ping1jing2 commented May 2, 2026 •
edited
Loading

only Ascend npu files changed and GPU CI failed due to environment issue.

https://github.com/sgl-project/sglang/actions/runs/25167172736/job/73778959974?pr=23835

@sglang-npu-bot sglang-npu-bot merged commit ebbaab5 into sgl-project:main May 2, 2026
154 of 177 checks passed
vguduruTT pushed a commit to vguduruTT/sglang that referenced this pull request May 2, 2026
@e-martirosian @ping1jing2
[NPU] Add GitHub test summary and deduplicate test code. Part 1 (sgl-…
46b3de2 
…project#23835)

Co-authored-by: Elizaveta Martirosian <elizaveta.martirosian@gmail.com>
Co-authored-by: root <root@localhost.localdomain>
Co-authored-by: Elizaveta Martirosian <you@example.com>
Co-authored-by: ronnie_zheng <zl19940307@163.com>
LucQueen pushed a commit to LucQueen/sglang that referenced this pull request May 12, 2026
@e-martirosian @ping1jing2 @LucQueen
[NPU] Add GitHub test summary and deduplicate test code. Part 1 (sgl-…
cae014f 
…project#23835)

Co-authored-by: Elizaveta Martirosian <elizaveta.martirosian@gmail.com>
Co-authored-by: root <root@localhost.localdomain>
Co-authored-by: Elizaveta Martirosian <you@example.com>
Co-authored-by: ronnie_zheng <zl19940307@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ping1jing2 ping1jing2 ping1jing2 approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@ping1jing2 ping1jing2

Labels

deepseek Multi-modal multi-modal language model npu run-ci

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@e-martirosian @ping1jing2 @sglang-npu-bot