Skip to content

Fix create_grammar_backend test calls with think_end_id #22158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ShangmingCai merged 2 commits into from
Apr 5, 2026
+4 −7
Merged

Fix create_grammar_backend test calls with think_end_id #22158

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d5fb607
Fix create_grammar_backend test calls with think_end_id
ShangmingCai Apr 5, 2026
8f66257
cleaner fix
ShangmingCai Apr 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions test/registered/unit/constrained/test_base_grammar_backend.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,7 +318,6 @@ def test_custom_backend_skips_reasoner_wrapping(self):

args = self._make_server_args("inner_r", reasoning_parser="deepseek")
tokenizer = MagicMock()
tokenizer.think_end_id = 42

result = create_grammar_backend(args, tokenizer, 32000)
# Custom backends return early, no reasoner wrapping applied
Expand Down Expand Up @@ -386,22 +385,21 @@ def test_reasoner_wrapping_on_builtin_backend(self, mock_outlines_cls):
mock_outlines_cls.return_value = mock_backend
args = self._make_server_args("outlines", reasoning_parser="deepseek")
tokenizer = MagicMock()
tokenizer.think_end_id = 42

result = create_grammar_backend(args, tokenizer, 32000)
result = create_grammar_backend(args, tokenizer, 32000, think_end_id=42)
self.assertIsInstance(result, ReasonerGrammarBackend)
self.assertEqual(result.think_end_id, 42)
self.assertIs(result.grammar_backend, mock_backend)

@patch("sglang.srt.constrained.outlines_backend.OutlinesGrammarBackend")
def test_no_reasoner_wrapping_without_think_end_id(self, mock_outlines_cls):
"""Without think_end_id on tokenizer, no reasoner wrapping."""
"""Without think_end_id passed in, no reasoner wrapping."""
mock_backend = MagicMock(spec=BaseGrammarBackend)
mock_outlines_cls.return_value = mock_backend
args = self._make_server_args("outlines", reasoning_parser="deepseek")
tokenizer = MagicMock(spec=[]) # No think_end_id attribute

result = create_grammar_backend(args, tokenizer, 32000)
result = create_grammar_backend(args, tokenizer, 32000, think_end_id=None)
self.assertIs(result, mock_backend)

@patch("sglang.srt.constrained.outlines_backend.OutlinesGrammarBackend")
Expand All @@ -411,9 +409,8 @@ def test_no_reasoner_wrapping_without_reasoning_parser(self, mock_outlines_cls):
mock_outlines_cls.return_value = mock_backend
args = self._make_server_args("outlines", reasoning_parser=None)
tokenizer = MagicMock()
tokenizer.think_end_id = 42

result = create_grammar_backend(args, tokenizer, 32000)
result = create_grammar_backend(args, tokenizer, 32000, think_end_id=42)
self.assertIs(result, mock_backend)

@patch("sglang.srt.constrained.xgrammar_backend.XGrammarGrammarBackend")
Expand Down
Loading