Skip to content

Fix create_grammar_backend test calls with think_end_id#22158

Merged
ShangmingCai merged 2 commits intomainfrom
fix-grammar-ci
Apr 5, 2026
Merged

Fix create_grammar_backend test calls with think_end_id#22158
ShangmingCai merged 2 commits intomainfrom
fix-grammar-ci

Conversation

@ShangmingCai
Copy link
Copy Markdown
Collaborator

@ShangmingCai ShangmingCai commented Apr 5, 2026

Motivation

Fix missing CI change of #22148

Modifications

Accuracy Tests

Speed Tests and Profiling

Checklist

Review and Merge Process

  1. Ping Merge Oncalls to start the process. See the PR Merge Process.
  2. Get approvals from CODEOWNERS and other reviewers.
  3. Trigger CI tests with comments or contact authorized users to do so.
    • Common commands include /tag-and-rerun-ci, /tag-run-ci-label, /rerun-failed-ci
  4. After green CI and required approvals, ask Merge Oncalls or people with Write permission to merge the PR.

@ShangmingCai
Copy link
Copy Markdown
Collaborator Author

/rerun-stage stage-a-test-cpu

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 5, 2026

✅ Triggered stage-a-test-cpu to run independently (skipping dependencies). View workflow run

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the unit tests in test_base_grammar_backend.py to explicitly pass the think_end_id argument when calling create_grammar_backend, ensuring the tests correctly handle scenarios with and without a reasoning parser. I have no feedback to provide.

@ShangmingCai
Copy link
Copy Markdown
Collaborator Author

Fixed.

image

@ShangmingCai
Copy link
Copy Markdown
Collaborator Author

/rerun-stage stage-a-test-cpu

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 5, 2026

✅ Triggered stage-a-test-cpu to run independently (skipping dependencies). View workflow run

@ShangmingCai
Copy link
Copy Markdown
Collaborator Author

Check again. Passed.
image

@ShangmingCai ShangmingCai merged commit 75ab75d into main Apr 5, 2026
80 of 86 checks passed
@ShangmingCai ShangmingCai deleted the fix-grammar-ci branch April 5, 2026 16:54
JustinTong0323 pushed a commit to JustinTong0323/sglang that referenced this pull request Apr 7, 2026
yhyang201 pushed a commit to yhyang201/sglang that referenced this pull request Apr 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant