Fix create_grammar_backend test calls with think_end_id#22158
Merged
ShangmingCai merged 2 commits intomainfrom Apr 5, 2026
Merged
Fix create_grammar_backend test calls with think_end_id#22158ShangmingCai merged 2 commits intomainfrom
ShangmingCai merged 2 commits intomainfrom
Conversation
Collaborator
Author
|
/rerun-stage stage-a-test-cpu |
Contributor
|
✅ Triggered |
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the unit tests in test_base_grammar_backend.py to explicitly pass the think_end_id argument when calling create_grammar_backend, ensuring the tests correctly handle scenarios with and without a reasoning parser. I have no feedback to provide.
Collaborator
Author
Collaborator
Author
|
/rerun-stage stage-a-test-cpu |
Contributor
|
✅ Triggered |
Collaborator
Author
JustinTong0323
pushed a commit
to JustinTong0323/sglang
that referenced
this pull request
Apr 7, 2026
Fridge003
pushed a commit
that referenced
this pull request
Apr 7, 2026
xiezhq-hermann
pushed a commit
to antgroup/sglang
that referenced
this pull request
Apr 7, 2026
yhyang201
pushed a commit
to yhyang201/sglang
that referenced
this pull request
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Motivation
Fix missing CI change of #22148
Modifications
Accuracy Tests
Speed Tests and Profiling
Checklist
Review and Merge Process
/tag-and-rerun-ci,/tag-run-ci-label,/rerun-failed-ci