[HiCache] return cached_tokens_details in sglext for streaming responses#22055
Open
vladnosiv wants to merge 1 commit intosgl-project:mainfrom
Open
[HiCache] return cached_tokens_details in sglext for streaming responses#22055vladnosiv wants to merge 1 commit intosgl-project:mainfrom
vladnosiv wants to merge 1 commit intosgl-project:mainfrom
Conversation
Signed-off-by: Vladislav Nosivskoy <vladnosiv@gmail.com>
vladnosiv
requested review from
CatherineSue,
JustinTong0323,
ispobock,
merrymercy and
slin1237
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces support for cached token details in OpenAI-compatible chat and completion streams, consolidating extension data into a single response chunk. It also adds a utility function for processing cached token metadata. Review feedback suggests simplifying the conditional logic for assigning routed experts to improve readability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Previous PRs: #17648 & #21764
sglext.cached_tokens_detailsis returned correctly in non-streaming chat/completions responses, but silently dropped in streaming mode. The backend populatescached_tokens_detailsinmeta_infofor every request, and the streaming loop already collects it but it was never extracted and emitted.