Skip to content

[HiCache] fix: graceful shutdown of pending async tasks in bench_mix.py #20276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hnyls2002 merged 2 commits into from
Mar 29, 2026
+8 −1
Merged

[HiCache] fix: graceful shutdown of pending async tasks in bench_mix.py #20276

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6d26731
fix: graceful shutdown of pending async tasks in bench_mix.py
alphabetc1 Mar 10, 2026
da03dea
Merge branch 'main' into fix/bench_mix
xiezhq-hermann Mar 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion benchmark/hicache/bench_mix.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -426,11 +426,13 @@ async def handle_request(self, user_data):

def request_sender(self):
async def request_loop():
tasks = []
while True:
if self.sent_requests - self.completed_requests < self.max_parallel:
new_request = self.user_generator.pop()
if new_request:
asyncio.create_task(self.handle_request(new_request))
task = asyncio.create_task(self.handle_request(new_request))
tasks.append(task)
self.sent_requests += 1
else:
await asyncio.sleep(0.05)
Expand All @@ -440,6 +442,11 @@ async def request_loop():
self.done = True
break

# Cancel all pending tasks and wait for them to finish
for task in tasks:
task.cancel()
await asyncio.gather(*tasks, return_exceptions=True)

loop = asyncio.new_event_loop()
asyncio.set_event_loop(loop)
loop.run_until_complete(request_loop())
Expand Down
Loading