[diffusion]: align sglang diffusion AMD pyproject_other.toml diffusion dependency with pyproject.toml#16225
Conversation
Summary of ChangesHello @ZiguanWang, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly improves the compatibility and performance of diffusion models on AMD/ROCm platforms. It achieves this by updating and aligning critical dependencies, integrating an external fix for Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request aligns the AMD diffusion dependencies in pyproject_other.toml with the main pyproject.toml, updates several packages, and removes previously vendored code. Specifically, it pins diffusers and runai_model_streamer, and uses a forked long-context-attention to address a specific issue. These changes also enable runai_model_streamer on ROCm, which was previously disabled, and appear to yield significant performance improvements based on the provided logs. The changes are well-motivated and look good. I have one suggestion to improve the maintainability of the dependency list.
|
/tag-and-rerun-ci |
|
I find CI test has some errors: I got the same errors in my local environment before this change, Maybe I can help these errors after the NEW YEAR Holiday, @mickqian |
76387af to
6335f61
Compare
Resolved by #16287 |
|
/rerun-failed-ci |
1 similar comment
|
/rerun-failed-ci |
|
@mickqian, @yhyang201 Can you help check this? |
|
/rerun-failed-ci |
04d0ac8 to
a488c89
Compare
|
chang |
|
@mickqian only one ci test failed because of timeout, can you help me rerun again? |
|
/rerun-failed-ci |
1 similar comment
|
/rerun-failed-ci |
13d4390 to
d053aa6
Compare
|
@yctseng0211 could you please help check the failed AMD tests in this PR? I think they are unrelated to the changes of this PR. |
checking, cc: @bingxche |
|
@hubertlu-tw I believe the failed AMD tests are unrelated to this PR, we will fix them in #17633 |
|
@HaiShaw Can you help me merge this PR? thanks |
…n dependency with pyproject.toml
4df3bf9 to
c295077
Compare
…n dependency with pyproject.toml (sgl-project#16225) Co-authored-by: roywang <roywang@amd.com>
…n dependency with pyproject.toml (sgl-project#16225) Co-authored-by: roywang <roywang@amd.com>
…n dependency with pyproject.toml (sgl-project#16225) Co-authored-by: roywang <roywang@amd.com>
…n dependency with pyproject.toml (sgl-project#16225) Co-authored-by: roywang <roywang@amd.com>
Motivation
align AMD pyproject_other.toml diffusion dependency with pyproject.toml
Modifications
Accuracy Tests
the output video is the same
Log before this change:
Log after this change:
Benchmarking and Profiling
Checklist
Review Process
/tag-run-ci-label,/rerun-failed-ci,/tag-and-rerun-ci) or contact authorized users to do so.