[DO NOT MERGE] test deepgemm warmup error - #11212
FlamingoPg wants to merge 2 commits into
Conversation
Summary of ChangesHello @FlamingoPg, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request, explicitly marked as "[DO NOT MERGE]", appears to be an experimental or diagnostic commit aimed at investigating a "deepgemm warmup error". It involves pinning the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request appears to be for testing a fix related to deepgemm warmup, as suggested by the title. The changes involve pinning the DeepGEMM dependency to a specific commit hash and adding a test comment. While pinning to a commit is good for reproducibility, using a Git tag is generally better for long-term maintainability. The added test comment should also be removed before this pull request is merged.
| repo-deepgemm | ||
| GIT_REPOSITORY https://github.com/sgl-project/DeepGEMM | ||
| GIT_TAG sgl | ||
| GIT_TAG 012e5aac28739a100909cfbf6e49f549605ba9d8 |
There was a problem hiding this comment.
Pinning dependencies to a specific commit hash is a good practice for ensuring reproducible builds. However, for better long-term maintainability and clarity, it's preferable to use a Git tag instead of a raw commit hash. Tags are more descriptive and make it easier to track which version of the dependency is being used. If this change is intended to be permanent, consider creating a tag for this commit in the DeepGEMM repository and referencing that tag here.
| ## test CI | ||
|
|
Motivation
Modifications
Accuracy Tests
Benchmarking and Profiling
Checklist