Skip to content

[DO NOT MERGE] test deepgemm warmup error - #11212

Closed
FlamingoPg wants to merge 2 commits into
sgl-project:mainfrom
FlamingoPg:sgl-kernel-ci-test
Closed

FlamingoPg wants to merge 2 commits into
sgl-project:mainfrom
FlamingoPg:sgl-kernel-ci-test

Conversation

@FlamingoPg

Copy link
Copy Markdown
Collaborator

Motivation

Modifications

Accuracy Tests

Benchmarking and Profiling

Checklist

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @FlamingoPg, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request, explicitly marked as "[DO NOT MERGE]", appears to be an experimental or diagnostic commit aimed at investigating a "deepgemm warmup error". It involves pinning the DeepGEMM dependency to a specific commit in the CMake configuration and adding a temporary comment in a Python initialization file, likely to trigger or test a Continuous Integration pipeline.

Highlights

  • DeepGEMM Dependency Pinning: The DeepGEMM repository dependency in sgl-kernel/CMakeLists.txt has been updated to a specific Git commit hash (012e5aac28739a100909cfbf6e49f549605ba9d8) instead of the sgl branch.
  • CI Test Marker: A comment ## test CI was added to the sgl-kernel/python/sgl_kernel/__init__.py file, likely as a temporary marker for CI testing purposes.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request appears to be for testing a fix related to deepgemm warmup, as suggested by the title. The changes involve pinning the DeepGEMM dependency to a specific commit hash and adding a test comment. While pinning to a commit is good for reproducibility, using a Git tag is generally better for long-term maintainability. The added test comment should also be removed before this pull request is merged.

Comment thread sgl-kernel/CMakeLists.txt
repo-deepgemm
GIT_REPOSITORY https://github.com/sgl-project/DeepGEMM
GIT_TAG sgl
GIT_TAG 012e5aac28739a100909cfbf6e49f549605ba9d8

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Pinning dependencies to a specific commit hash is a good practice for ensuring reproducible builds. However, for better long-term maintainability and clarity, it's preferable to use a Git tag instead of a raw commit hash. Tags are more descriptive and make it easier to track which version of the dependency is being used. If this change is intended to be permanent, consider creating a tag for this commit in the DeepGEMM repository and referencing that tag here.

Comment on lines +1 to +2
## test CI

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This comment and the following blank line appear to be temporary additions for testing the CI pipeline. They should be removed before merging to keep the codebase clean.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants