Make settings modal stable and sync split scrolling by pixels - #196
Merged
alecdotdev merged 2 commits intoJul 13, 2026
Merged
Conversation
HTML export now renders from the Markdown source, rewrites local Markdown links, embeds local images as data URLs, and includes frontmatter metadata as a static properties block. Add a reload-from-disk action through the titlebar, native menu, and F5 with dirty-state protection. The editor formatting toolbar and the application titlebar toolbar can now be configured from settings, including visibility and order. The export path asks whether to open the saved HTML file in the system default app. PDF export still delegates to the system print dialog because that path does not expose the saved file path. fixes sftwrdotdev#154 fixes sftwrdotdev#163 fixes sftwrdotdev#185
Settings now behaves as a true modal: backdrop clicks no longer light-dismiss it, the header can drag the dialog, and custom edge and corner handles resize it without the native resize jitter. Toolbar customization is grouped into collapsed accordions with chevrons, and the settings wiring test checks that translated interactive labels exist for every supported language. Split-pane scroll sync now exchanges pixel segment positions instead of source-line guesses, so preview-to-editor sync stays aligned across different font sizes and frontmatter panel states. refs sftwrdotdev#154
daniel-grabowski
marked this pull request as ready for review
July 7, 2026 13:47
This was referenced Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacking
This is a follow-up to #195. It should be reviewed after #195 because it builds on the toolbar settings structure added there.
Testing
npm run test:settings-scrollnpm run check(0 errors, 0 warnings)npm run buildcargo xwin check --target x86_64-pc-windows-msvcgit diff --cached --checkNotes
No Windows release artifacts or local
adhoc-sdlcfiles are included.