Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update base64 #3034

Merged
merged 1 commit into from
Oct 15, 2018
Merged

Update base64 #3034

merged 1 commit into from
Oct 15, 2018

Conversation

Eijebong
Copy link
Contributor

@Eijebong Eijebong commented Sep 8, 2018

This change is Reviewable

bors-servo pushed a commit to servo/servo that referenced this pull request Sep 8, 2018
WIP: Update hyper to 0.12

Left to do:
 - Fix the influent::Client call
 - servo/webrender#3034
 - hyperium/mime#91
 - sfackler/typed-headers#3 (still need a lot of work)
 - https://bugzilla.mozilla.org/show_bug.cgi?id=1489792
 - Merge and release the ws stuff (I'll do it once I know everything is ok)
 - Merge and release the influent stuff (Same here, I'll do it once I know everything is ok)
 - #21325
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21644)
<!-- Reviewable:end -->
bors-servo pushed a commit to servo/servo that referenced this pull request Sep 8, 2018
WIP: Update hyper to 0.12

Left to do:
 - Fix the influent::Client call
 - servo/webrender#3034
 - hyperium/mime#91
 - sfackler/typed-headers#3 (still need a lot of work)
 - https://bugzilla.mozilla.org/show_bug.cgi?id=1489792
 - Merge and release the ws stuff (I'll do it once I know everything is ok)
 - Merge and release the influent stuff (Same here, I'll do it once I know everything is ok)
 - #21325
 - Fix unit tests
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21644)
<!-- Reviewable:end -->
bors-servo pushed a commit to servo/servo that referenced this pull request Sep 9, 2018
WIP: Update hyper to 0.12

Left to do:
 - Fix the influent::Client call
 - servo/webrender#3034
 - hyperium/mime#91
 - sfackler/typed-headers#3 (still need a lot of work)
 - https://bugzilla.mozilla.org/show_bug.cgi?id=1489792
 - Merge and release the ws stuff (I'll do it once I know everything is ok)
 - Merge and release the influent stuff (Same here, I'll do it once I know everything is ok)
 - #21325
 - Fix unit tests
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21644)
<!-- Reviewable:end -->
bors-servo pushed a commit to servo/servo that referenced this pull request Sep 9, 2018
WIP: Update hyper to 0.12

Left to do:
 - Fix the influent::Client call
 - servo/webrender#3034
 - hyperium/mime#91
 - sfackler/typed-headers#3 (still need a lot of work)
 - https://bugzilla.mozilla.org/show_bug.cgi?id=1489792
 - Merge and release the ws stuff (I'll do it once I know everything is ok)
 - Merge and release the influent stuff (Same here, I'll do it once I know everything is ok)
 - #21325
 - Fix unit tests
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21644)
<!-- Reviewable:end -->
bors-servo pushed a commit to servo/servo that referenced this pull request Sep 9, 2018
WIP: Update hyper to 0.12

Left to do:
 - Fix the influent::Client call
 - servo/webrender#3034
 - hyperium/mime#91
 - sfackler/typed-headers#3 (still need a lot of work)
 - https://bugzilla.mozilla.org/show_bug.cgi?id=1489792
 - Merge and release the ws stuff (I'll do it once I know everything is ok)
 - Merge and release the influent stuff (Same here, I'll do it once I know everything is ok)
 - #21325
 - Fix unit tests
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21644)
<!-- Reviewable:end -->
bors-servo pushed a commit to servo/servo that referenced this pull request Sep 9, 2018
WIP: Update hyper to 0.12

Left to do:
 - Fix the influent::Client call
 - servo/webrender#3034
 - hyperium/mime#91
 - sfackler/typed-headers#3 (still need a lot of work)
 - https://bugzilla.mozilla.org/show_bug.cgi?id=1489792
 - Merge and release the ws stuff (I'll do it once I know everything is ok)
 - Merge and release the influent stuff (Same here, I'll do it once I know everything is ok)
 - #21325
 - Fix unit tests
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21644)
<!-- Reviewable:end -->
bors-servo pushed a commit to servo/servo that referenced this pull request Sep 9, 2018
WIP: Update hyper to 0.12

Left to do:
 - Fix the influent::Client call
 - servo/webrender#3034
 - hyperium/mime#91
 - sfackler/typed-headers#3 (still need a lot of work)
 - https://bugzilla.mozilla.org/show_bug.cgi?id=1489792
 - Merge and release the ws stuff (I'll do it once I know everything is ok)
 - Merge and release the influent stuff (Same here, I'll do it once I know everything is ok)
 - #21325
 - Fix unit tests
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21644)
<!-- Reviewable:end -->
bors-servo pushed a commit to servo/servo that referenced this pull request Sep 10, 2018
WIP: Update hyper to 0.12

Left to do:
 - Fix the influent::Client call
 - servo/webrender#3034
 - hyperium/mime#91
 - sfackler/typed-headers#3 (still need a lot of work)
 - https://bugzilla.mozilla.org/show_bug.cgi?id=1489792
 - Merge and release the ws stuff (I'll do it once I know everything is ok)
 - Merge and release the influent stuff (Same here, I'll do it once I know everything is ok)
 - #21325
 - Fix unit tests
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21644)
<!-- Reviewable:end -->
bors-servo pushed a commit to servo/servo that referenced this pull request Sep 11, 2018
WIP: Update hyper to 0.12

Left to do:
 - Fix the influent::Client call
 - servo/webrender#3034
 - hyperium/mime#91
 - sfackler/typed-headers#3 (still need a lot of work)
 - https://bugzilla.mozilla.org/show_bug.cgi?id=1489792
 - Merge and release the ws stuff (I'll do it once I know everything is ok)
 - Merge and release the influent stuff (Same here, I'll do it once I know everything is ok)
 - #21325
 - Fix unit tests
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21644)
<!-- Reviewable:end -->
bors-servo pushed a commit to servo/servo that referenced this pull request Sep 11, 2018
WIP: Update hyper to 0.12

Left to do:
 - Fix the influent::Client call
 - servo/webrender#3034
 - hyperium/mime#91
 - sfackler/typed-headers#3 (still need a lot of work)
 - https://bugzilla.mozilla.org/show_bug.cgi?id=1489792
 - Merge and release the ws stuff (I'll do it once I know everything is ok)
 - Merge and release the influent stuff (Same here, I'll do it once I know everything is ok)
 - #21325
 - Fix unit tests
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21644)
<!-- Reviewable:end -->
bors-servo pushed a commit to servo/servo that referenced this pull request Sep 12, 2018
WIP: Update hyper to 0.12

Left to do:
 - Fix the influent::Client call
 - servo/webrender#3034
 - hyperium/mime#91
 - sfackler/typed-headers#3 (still need a lot of work)
 - https://bugzilla.mozilla.org/show_bug.cgi?id=1489792
 - Merge and release the ws stuff (I'll do it once I know everything is ok)
 - Merge and release the influent stuff (Same here, I'll do it once I know everything is ok)
 - #21325
 - Fix unit tests
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21644)
<!-- Reviewable:end -->
bors-servo pushed a commit to servo/servo that referenced this pull request Sep 13, 2018
WIP: Update hyper to 0.12

Left to do:
 - Fix the influent::Client call
 - servo/webrender#3034
 - hyperium/mime#91
 - sfackler/typed-headers#3 (still need a lot of work)
 - Merge and release the ws stuff (I'll do it once I know everything is ok)
 - Merge and release the influent stuff (Same here, I'll do it once I know everything is ok)
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21644)
<!-- Reviewable:end -->
bors-servo pushed a commit to servo/servo that referenced this pull request Sep 15, 2018
WIP: Update hyper to 0.12

Left to do:
 - Fix the influent::Client call
 - servo/webrender#3034
 - hyperium/mime#91
 - sfackler/typed-headers#3 (still need a lot of work)
 - Merge and release the ws stuff (I'll do it once I know everything is ok)
 - Merge and release the influent stuff (Same here, I'll do it once I know everything is ok)
 - hyperium/hyper#1655
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21644)
<!-- Reviewable:end -->
@atouchet
Copy link
Contributor

base64 0.9.3 is now out.

@kvark
Copy link
Member

kvark commented Sep 18, 2018

@pyfisch @Eijebong why is this WIP?

@Eijebong
Copy link
Contributor Author

@kvark Because it would block updating wr in servo if it was merged while hyperup isn't ready to land

bors-servo pushed a commit to servo/servo that referenced this pull request Sep 25, 2018
WIP: Update hyper to 0.12

Left to do:
 - Fix the influent::Client call
 - servo/webrender#3034
 - hyperium/mime#91
 - sfackler/typed-headers#3 (still need a lot of work)
 - Merge and release the ws stuff (I'll do it once I know everything is ok)
 - Merge and release the influent stuff (Same here, I'll do it once I know everything is ok)
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21644)
<!-- Reviewable:end -->
bors-servo pushed a commit to servo/servo that referenced this pull request Sep 26, 2018
WIP: Update hyper to 0.12

Left to do:
 - Fix the influent::Client call
 - servo/webrender#3034
 - hyperium/mime#91
 - sfackler/typed-headers#3 (still need a lot of work)
 - Merge and release the ws stuff (I'll do it once I know everything is ok)
 - Merge and release the influent stuff (Same here, I'll do it once I know everything is ok)
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21644)
<!-- Reviewable:end -->
@gw3583
Copy link
Contributor

gw3583 commented Oct 5, 2018

@Eijebong What's the status of this?

@Eijebong
Copy link
Contributor Author

Eijebong commented Oct 5, 2018

@gw3583 No real changes unfortunately; Tests are green on servo's side, need to make it mergeable but it still requires a ton of work (and I'm lacking motivation these days :/)

bors-servo pushed a commit to servo/servo that referenced this pull request Oct 10, 2018
WIP: Update hyper to 0.12

Left to do:
 - Fix the influent::Client call
 - servo/webrender#3034
 - hyperium/mime#91
 - sfackler/typed-headers#3 (still need a lot of work)
 - Merge and release the ws stuff (I'll do it once I know everything is ok)
 - Merge and release the influent stuff (Same here, I'll do it once I know everything is ok)
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21644)
<!-- Reviewable:end -->
bors-servo pushed a commit to servo/servo that referenced this pull request Oct 10, 2018
WIP: Update hyper to 0.12

Left to do:
 - Fix the influent::Client call
 - servo/webrender#3034
 - hyperium/mime#91
 - sfackler/typed-headers#3 (still need a lot of work)
 - Merge and release the ws stuff (I'll do it once I know everything is ok)
 - Merge and release the influent stuff (Same here, I'll do it once I know everything is ok)
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21644)
<!-- Reviewable:end -->
@Eijebong Eijebong changed the title WIP: Update base64 Update base64 Oct 15, 2018
@Eijebong
Copy link
Contributor Author

Ok, ready, let's do this 🎉

bors-servo pushed a commit to servo/servo that referenced this pull request Oct 15, 2018
WIP: Update hyper to 0.12

Left to do:
 - servo/webrender#3034
 - servo/hyper_serde#20
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21644)
<!-- Reviewable:end -->
@gw3583
Copy link
Contributor

gw3583 commented Oct 15, 2018

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit a52044e has been approved by gw3583

@bors-servo
Copy link
Contributor

⌛ Testing commit a52044e with merge f0221fa...

bors-servo pushed a commit that referenced this pull request Oct 15, 2018
Update base64

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3034)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - status-appveyor, status-taskcluster
Approved by: gw3583
Pushing f0221fa to master...

@bors-servo bors-servo merged commit a52044e into servo:master Oct 15, 2018
bors-servo pushed a commit to servo/servo that referenced this pull request Oct 15, 2018
WIP: Update hyper to 0.12

Left to do:
 - servo/webrender#3034
 - servo/hyper_serde#20
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21644)
<!-- Reviewable:end -->
bors-servo pushed a commit to servo/servo that referenced this pull request Oct 16, 2018
WIP: Update hyper to 0.12

Left to do:
 - servo/webrender#3034
 - servo/hyper_serde#20
 - rust-lang/rust#55105
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21644)
<!-- Reviewable:end -->
bors-servo pushed a commit to servo/servo that referenced this pull request Oct 16, 2018
WIP: Update hyper to 0.12

Left to do:
 - servo/webrender#3034
 - servo/hyper_serde#20
 - rust-lang/rust#55105
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21644)
<!-- Reviewable:end -->
bors-servo pushed a commit to servo/servo that referenced this pull request Oct 16, 2018
WIP: Update hyper to 0.12

Left to do:
 - servo/webrender#3034
 - servo/hyper_serde#20
 - rust-lang/rust#55105
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21644)
<!-- Reviewable:end -->
bors-servo pushed a commit to servo/servo that referenced this pull request Oct 16, 2018
WIP: Update hyper to 0.12

Left to do:
 - servo/webrender#3034
 - servo/hyper_serde#20
 - rust-lang/rust#55105
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21644)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants