This repository has been archived by the owner on Dec 14, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@Eijebong looks good to me |
Closed
So I have no idea why, but @KiChjang asked me to rebase this, it's done now ;) |
Remove "[WIP]" from the commit title and I will land this. |
@nox Do we want to land this now ? |
Actually not sure. |
Yeah, I think it's better to wait for everything to be ready (not that this crate is super active but you never know). |
Closed
Eijebong
force-pushed
the
bump_mime
branch
2 times, most recently
from
September 8, 2018 19:42
72d4e44
to
e067264
Compare
Eijebong
changed the title
[WIP] Bump mime to 0.3 and hyper to 0.11
[WIP] Bump mime to 0.3 and hyper to 0.12
Sep 13, 2018
Eijebong
force-pushed
the
bump_mime
branch
2 times, most recently
from
October 7, 2018 00:16
a366da8
to
828b1ff
Compare
Eijebong
changed the title
[WIP] Bump mime to 0.3 and hyper to 0.12
Bump mime to 0.3 and hyper to 0.12
Oct 15, 2018
Ok this is ready now ! |
bors-servo
pushed a commit
to servo/servo
that referenced
this pull request
Oct 15, 2018
WIP: Update hyper to 0.12 Left to do: - servo/webrender#3034 - servo/hyper_serde#20 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21644) <!-- Reviewable:end -->
bors-servo
pushed a commit
to servo/servo
that referenced
this pull request
Oct 15, 2018
WIP: Update hyper to 0.12 Left to do: - servo/webrender#3034 - servo/hyper_serde#20 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21644) <!-- Reviewable:end -->
bors-servo
pushed a commit
to servo/servo
that referenced
this pull request
Oct 16, 2018
WIP: Update hyper to 0.12 Left to do: - servo/webrender#3034 - servo/hyper_serde#20 - rust-lang/rust#55105 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21644) <!-- Reviewable:end -->
bors-servo
pushed a commit
to servo/servo
that referenced
this pull request
Oct 16, 2018
WIP: Update hyper to 0.12 Left to do: - servo/webrender#3034 - servo/hyper_serde#20 - rust-lang/rust#55105 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21644) <!-- Reviewable:end -->
bors-servo
pushed a commit
to servo/servo
that referenced
this pull request
Oct 16, 2018
WIP: Update hyper to 0.12 Left to do: - servo/webrender#3034 - servo/hyper_serde#20 - rust-lang/rust#55105 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21644) <!-- Reviewable:end -->
bors-servo
pushed a commit
to servo/servo
that referenced
this pull request
Oct 16, 2018
WIP: Update hyper to 0.12 Left to do: - servo/webrender#3034 - servo/hyper_serde#20 - rust-lang/rust#55105 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21644) <!-- Reviewable:end -->
jdm
approved these changes
Nov 1, 2018
bors r+ |
🔒 Permission denied Existing reviewers: click here to make jdm a reviewer |
bors r+ |
bors bot
added a commit
that referenced
this pull request
Nov 1, 2018
20: Bump mime to 0.3 and hyper to 0.12 r=jdm a=Eijebong ping @avadacatavra Co-authored-by: Bastien Orivel <[email protected]>
Build succeeded |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ping @avadacatavra