Skip to content

issue-468: Fix empty/whitespace string converting to array type #469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nblumhardt merged 3 commits into from
Apr 9, 2026
+25 −0
Merged

issue-468: Fix empty/whitespace string converting to array type #469

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
31a7ce8
issue-468: Fix empty/whitespace string converting to array type
gyurebalint-CID Mar 28, 2026
0dad5b3
issue-468: regression test asserting that a non-empty single string (…
gyurebalint-CID Mar 28, 2026
2cc6358
issue-468 change dummy sting value
gyurebalint-CID Mar 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/Serilog.Settings.Configuration/Settings/Configuration/StringArgumentValue.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,11 @@ public StringArgumentValue(string providedValue)
}
}

if (toType.IsArray && string.IsNullOrWhiteSpace(argumentValue))
{
return Array.CreateInstance(toType.GetElementType()!, 0);
}

return Convert.ChangeType(argumentValue, toType, resolutionContext.ReaderOptions.FormatProvider);
}

Expand Down
20 changes: 20 additions & 0 deletions test/Serilog.Settings.Configuration.Tests/StringArgumentValueTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,4 +374,24 @@ public void StringValuesConvertToString(string expected)

Assert.Equal(expected, actual);
}

[Theory]
[InlineData("")]
[InlineData(" ")]
public void EmptyOrWhitespaceStringConvertsToEmptyArrayForArrayType(string input)
{
var value = new StringArgumentValue(input);
var actual = value.ConvertTo(typeof(string[]), new ResolutionContext());

var array = Assert.IsType<string[]>(actual);
Assert.Empty(array);
}

[Fact]
public void NonEmptyStringDoesNotConvertToArray()
{
var value = new StringArgumentValue("Information");
Assert.Throws<InvalidCastException>(() =>
value.ConvertTo(typeof(string[]), new ResolutionContext()));
}
}
Loading