issue-468: Fix empty/whitespace string converting to array type#469
Merged
nblumhardt merged 3 commits intoserilog:devfrom Apr 9, 2026
Merged
issue-468: Fix empty/whitespace string converting to array type#469nblumhardt merged 3 commits intoserilog:devfrom
nblumhardt merged 3 commits intoserilog:devfrom
Conversation
…e.g. `"cookie1"`) does not silently convert to a single-element array
Contributor
|
Hello everyone. |
Member
|
Thanks @gyurebalint-CID 👍 |
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #468
Problem
When a configuration value is an empty or whitespace-only string and the target type is an array (e.g.
string[]),StringArgumentValue.ConvertTofalls through to parsing logic that produces unexpected results instead of returning an empty array.Changes
StringArgumentValue.csstring.IsNullOrEmptytostring.IsNullOrWhiteSpacein the array-type guard, so that empty ("") and whitespace-only (" ") values both return an empty array.StringArgumentValueTests.cs[Theory]test with[InlineData("")]and[InlineData(" ")]asserting that empty/whitespace strings convert to an emptystring[]."cookie1")does not silently convert to a single-element array, preserving the maintainer's
original intent from issue InvalidCastException when enricher Args contains empty JSON array for params string[] parameter (regression in .NET 10) #468.
Why
IsNullOrWhiteSpaceoverIsNullOrEmpty?A whitespace-only string like
" "is not meaningful array content. Without this, it would fall through and produce an array containing a whitespace string — a subtle bug. No one intentionally configures" "as valid array input; if structured values are needed, JSON arrays should be used instead.