Skip to content

Avoid deferring gateway event deserialization #3119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 8, 2025
Merged

Avoid deferring gateway event deserialization #3119

merged 5 commits into from
Mar 8, 2025

Conversation

@mkrasnitski
Copy link
Collaborator

@mkrasnitski mkrasnitski commented Feb 16, 2025 •
edited
Loading

Followup to #3114.

By using an intermediate untagged enum with an Unknown variant, we can process sequence numbers for unknown events without cloning the json payload.

@github-actions github-actions bot added model Related to the `model` module. gateway Related to the `gateway` module. labels Feb 16, 2025
@GnomedDev
Copy link
Member

GnomedDev commented Feb 16, 2025 •
edited
Loading

@mkrasnitski You can probably solve the typesize error using typesize(with = "") and providing a function with the signature fn(Box<str>) -> usize returning str::len.

@mkrasnitski mkrasnitski added the breaking change The public API is changed, resulting in miscompilations or unexpected new behaviour for users label Feb 18, 2025
@mkrasnitski
Avoid deferring gateway event deserialization
2bc7d61 
By using an intermediate untagged enum with an `Unknown` variant, we can
process sequence numbers for unknown events without cloning the json
payload in the hot path.
@mkrasnitski
Fix typesize
4a521ae
@mkrasnitski
Use RawValue instead of JsonMap to prevent tree construction
30289fc 
Also, deserialize directly rather than calling `serde_json::from_str`.
@mkrasnitski
Fix typesize again
71c4296
@mkrasnitski mkrasnitski force-pushed the gateway-deserialization branch from bd7ddfb to 71c4296 Compare March 7, 2025 21:02
@arqunis arqunis merged commit 64617d7 into serenity-rs:next Mar 8, 2025
24 checks passed
mkrasnitski added a commit to mkrasnitski/serenity that referenced this pull request Mar 10, 2025
@mkrasnitski
Avoid deferring gateway event deserialization (serenity-rs#3119)
12b02d1 
Followup to serenity-rs#3114.

By using an intermediate untagged enum with an `Unknown` variant, we can
process sequence numbers for unknown events without cloning the json
payload.
mkrasnitski added a commit to mkrasnitski/serenity that referenced this pull request Mar 11, 2025
@mkrasnitski
Avoid deferring gateway event deserialization (serenity-rs#3119)
10bfbf1 
Followup to serenity-rs#3114.

By using an intermediate untagged enum with an `Unknown` variant, we can
process sequence numbers for unknown events without cloning the json
payload.
@mkrasnitski mkrasnitski deleted the gateway-deserialization branch March 11, 2025 23:49
GnomedDev pushed a commit to GnomedDev/serenity that referenced this pull request Mar 26, 2025
@mkrasnitski @GnomedDev
Avoid deferring gateway event deserialization (serenity-rs#3119)
745c785 
Followup to serenity-rs#3114.

By using an intermediate untagged enum with an `Unknown` variant, we can
process sequence numbers for unknown events without cloning the json
payload.
GnomedDev pushed a commit to GnomedDev/serenity that referenced this pull request Mar 26, 2025
@mkrasnitski @GnomedDev
Avoid deferring gateway event deserialization (serenity-rs#3119)
98bc9b6 
Followup to serenity-rs#3114.

By using an intermediate untagged enum with an `Unknown` variant, we can
process sequence numbers for unknown events without cloning the json
payload.
GnomedDev pushed a commit that referenced this pull request Apr 28, 2025
@mkrasnitski @GnomedDev
Avoid deferring gateway event deserialization (#3119)
05b5780 
Followup to #3114.

By using an intermediate untagged enum with an `Unknown` variant, we can
process sequence numbers for unknown events without cloning the json
payload.
GnomedDev pushed a commit that referenced this pull request May 19, 2025
@mkrasnitski @GnomedDev
Avoid deferring gateway event deserialization (#3119)
5318c1a 
Followup to #3114.

By using an intermediate untagged enum with an `Unknown` variant, we can
process sequence numbers for unknown events without cloning the json
payload.
mkrasnitski added a commit to mkrasnitski/serenity that referenced this pull request Jun 30, 2025
@mkrasnitski
Avoid deferring gateway event deserialization (serenity-rs#3119)
e2a551f 
Followup to serenity-rs#3114.

By using an intermediate untagged enum with an `Unknown` variant, we can
process sequence numbers for unknown events without cloning the json
payload.
mkrasnitski added a commit to mkrasnitski/serenity that referenced this pull request Jun 30, 2025
@mkrasnitski
Avoid deferring gateway event deserialization (serenity-rs#3119)
56e4e8f 
Followup to serenity-rs#3114.

By using an intermediate untagged enum with an `Unknown` variant, we can
process sequence numbers for unknown events without cloning the json
payload.
mkrasnitski added a commit to mkrasnitski/serenity that referenced this pull request Jun 30, 2025
@mkrasnitski
Avoid deferring gateway event deserialization (serenity-rs#3119)
a2f7809 
Followup to serenity-rs#3114.

By using an intermediate untagged enum with an `Unknown` variant, we can
process sequence numbers for unknown events without cloning the json
payload.
mkrasnitski added a commit to mkrasnitski/serenity that referenced this pull request Jul 28, 2025
@mkrasnitski
Avoid deferring gateway event deserialization (serenity-rs#3119)
6718bb0 
Followup to serenity-rs#3114.

By using an intermediate untagged enum with an `Unknown` variant, we can
process sequence numbers for unknown events without cloning the json
payload.
mkrasnitski added a commit to mkrasnitski/serenity that referenced this pull request Jul 28, 2025
@mkrasnitski
Avoid deferring gateway event deserialization (serenity-rs#3119)
c462377 
Followup to serenity-rs#3114.

By using an intermediate untagged enum with an `Unknown` variant, we can
process sequence numbers for unknown events without cloning the json
payload.
mkrasnitski added a commit to mkrasnitski/serenity that referenced this pull request Oct 7, 2025
@mkrasnitski
Avoid deferring gateway event deserialization (serenity-rs#3119)
26498f1 
Followup to serenity-rs#3114.

By using an intermediate untagged enum with an `Unknown` variant, we can
process sequence numbers for unknown events without cloning the json
payload.
mkrasnitski added a commit to mkrasnitski/serenity that referenced this pull request Oct 7, 2025
@mkrasnitski
Avoid deferring gateway event deserialization (serenity-rs#3119)
c1496ee 
Followup to serenity-rs#3114.

By using an intermediate untagged enum with an `Unknown` variant, we can
process sequence numbers for unknown events without cloning the json
payload.
mkrasnitski added a commit to mkrasnitski/serenity that referenced this pull request Oct 7, 2025
@mkrasnitski
Avoid deferring gateway event deserialization (serenity-rs#3119)
8f2a5c0 
Followup to serenity-rs#3114.

By using an intermediate untagged enum with an `Unknown` variant, we can
process sequence numbers for unknown events without cloning the json
payload.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arqunis arqunis arqunis approved these changes

@GnomedDev GnomedDev GnomedDev approved these changes

Assignees

No one assigned

Labels

breaking change The public API is changed, resulting in miscompilations or unexpected new behaviour for users gateway Related to the `gateway` module. model Related to the `model` module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mkrasnitski @GnomedDev @arqunis