Avoid temporarily deserializing gateway messages to an untyped enum+map tree #3114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
model
xacrimon
force-pushed
the
skip-intermediate-deser-btreemap-tree
branch
from
e21c4b6 to
5fe2801
Compare
mkrasnitski
requested changes
Feb 15, 2025
Collaborator
mkrasnitski
left a comment
mkrasnitski
left a comment
There was a problem hiding this comment.
Overall this is definitely an improvement. It does suck that we're cloning the json data once, but for now we have to defer deserialization of Event in order to process the value of seq even if we fail to parse the event.
This deserves a rework but for now it's fine.
mkrasnitski
reviewed
Feb 15, 2025
Contributor
Author
|
@mkrasnitski ready for another look now |
Collaborator
|
Can you rebase onto latest |
xacrimon
force-pushed
the
skip-intermediate-deser-btreemap-tree
branch
from
9440e4e to
d8d1e7b
Compare
Contributor
Author
|
rebased |
mkrasnitski
approved these changes
Feb 16, 2025
arqunis
approved these changes
Feb 16, 2025
arqunis
added
enhancement
mkrasnitski
pushed a commit
to mkrasnitski/serenity
that referenced
this pull request
Mar 5, 2025
…ap tree (serenity-rs#3114) Avoid temporarily deserializing gateway messages to a `serde_json::Map<String, Value>` before typed deserialization to an `Event`. Previously, this meant the creation of a `serde_json::Value` tree, causing creation and immediately after the destruction of upwards of hundreds to thousands of owned strings and btreemaps for every handled gateway event.
mkrasnitski
pushed a commit
to mkrasnitski/serenity
that referenced
this pull request
Mar 5, 2025
…ap tree (serenity-rs#3114) Avoid temporarily deserializing gateway messages to a `serde_json::Map<String, Value>` before typed deserialization to an `Event`. Previously, this meant the creation of a `serde_json::Value` tree, causing creation and immediately after the destruction of upwards of hundreds to thousands of owned strings and btreemaps for every handled gateway event.
mkrasnitski
pushed a commit
to mkrasnitski/serenity
that referenced
this pull request
Mar 7, 2025
…ap tree (serenity-rs#3114) Avoid temporarily deserializing gateway messages to a `serde_json::Map<String, Value>` before typed deserialization to an `Event`. Previously, this meant the creation of a `serde_json::Value` tree, causing creation and immediately after the destruction of upwards of hundreds to thousands of owned strings and btreemaps for every handled gateway event.
arqunis
pushed a commit
that referenced
this pull request
Mar 8, 2025
Followup to #3114. By using an intermediate untagged enum with an `Unknown` variant, we can process sequence numbers for unknown events without cloning the json payload.
mkrasnitski
pushed a commit
to mkrasnitski/serenity
that referenced
this pull request
Mar 10, 2025
…ap tree (serenity-rs#3114) Avoid temporarily deserializing gateway messages to a `serde_json::Map<String, Value>` before typed deserialization to an `Event`. Previously, this meant the creation of a `serde_json::Value` tree, causing creation and immediately after the destruction of upwards of hundreds to thousands of owned strings and btreemaps for every handled gateway event.
mkrasnitski
added a commit
to mkrasnitski/serenity
that referenced
this pull request
Mar 10, 2025
Followup to serenity-rs#3114. By using an intermediate untagged enum with an `Unknown` variant, we can process sequence numbers for unknown events without cloning the json payload.
mkrasnitski
pushed a commit
to mkrasnitski/serenity
that referenced
this pull request
Mar 11, 2025
…ap tree (serenity-rs#3114) Avoid temporarily deserializing gateway messages to a `serde_json::Map<String, Value>` before typed deserialization to an `Event`. Previously, this meant the creation of a `serde_json::Value` tree, causing creation and immediately after the destruction of upwards of hundreds to thousands of owned strings and btreemaps for every handled gateway event.
mkrasnitski
added a commit
to mkrasnitski/serenity
that referenced
this pull request
Mar 11, 2025
Followup to serenity-rs#3114. By using an intermediate untagged enum with an `Unknown` variant, we can process sequence numbers for unknown events without cloning the json payload.
GnomedDev
pushed a commit
to GnomedDev/serenity
that referenced
this pull request
Mar 26, 2025
…ap tree (serenity-rs#3114) Avoid temporarily deserializing gateway messages to a `serde_json::Map<String, Value>` before typed deserialization to an `Event`. Previously, this meant the creation of a `serde_json::Value` tree, causing creation and immediately after the destruction of upwards of hundreds to thousands of owned strings and btreemaps for every handled gateway event.
GnomedDev
pushed a commit
to GnomedDev/serenity
that referenced
this pull request
Mar 26, 2025
Followup to serenity-rs#3114. By using an intermediate untagged enum with an `Unknown` variant, we can process sequence numbers for unknown events without cloning the json payload.
GnomedDev
pushed a commit
to GnomedDev/serenity
that referenced
this pull request
Mar 26, 2025
…ap tree (serenity-rs#3114) Avoid temporarily deserializing gateway messages to a `serde_json::Map<String, Value>` before typed deserialization to an `Event`. Previously, this meant the creation of a `serde_json::Value` tree, causing creation and immediately after the destruction of upwards of hundreds to thousands of owned strings and btreemaps for every handled gateway event.
GnomedDev
pushed a commit
to GnomedDev/serenity
that referenced
this pull request
Mar 26, 2025
Followup to serenity-rs#3114. By using an intermediate untagged enum with an `Unknown` variant, we can process sequence numbers for unknown events without cloning the json payload.
GnomedDev
pushed a commit
that referenced
this pull request
Apr 28, 2025
…ap tree (#3114) Avoid temporarily deserializing gateway messages to a `serde_json::Map<String, Value>` before typed deserialization to an `Event`. Previously, this meant the creation of a `serde_json::Value` tree, causing creation and immediately after the destruction of upwards of hundreds to thousands of owned strings and btreemaps for every handled gateway event.
GnomedDev
pushed a commit
that referenced
this pull request
Apr 28, 2025
Followup to #3114. By using an intermediate untagged enum with an `Unknown` variant, we can process sequence numbers for unknown events without cloning the json payload.
GnomedDev
pushed a commit
that referenced
this pull request
May 19, 2025
…ap tree (#3114) Avoid temporarily deserializing gateway messages to a `serde_json::Map<String, Value>` before typed deserialization to an `Event`. Previously, this meant the creation of a `serde_json::Value` tree, causing creation and immediately after the destruction of upwards of hundreds to thousands of owned strings and btreemaps for every handled gateway event.
GnomedDev
pushed a commit
that referenced
this pull request
May 19, 2025
Followup to #3114. By using an intermediate untagged enum with an `Unknown` variant, we can process sequence numbers for unknown events without cloning the json payload.
mkrasnitski
pushed a commit
to mkrasnitski/serenity
that referenced
this pull request
Jun 30, 2025
…ap tree (serenity-rs#3114) Avoid temporarily deserializing gateway messages to a `serde_json::Map<String, Value>` before typed deserialization to an `Event`. Previously, this meant the creation of a `serde_json::Value` tree, causing creation and immediately after the destruction of upwards of hundreds to thousands of owned strings and btreemaps for every handled gateway event.
mkrasnitski
added a commit
to mkrasnitski/serenity
that referenced
this pull request
Jun 30, 2025
Followup to serenity-rs#3114. By using an intermediate untagged enum with an `Unknown` variant, we can process sequence numbers for unknown events without cloning the json payload.
mkrasnitski
pushed a commit
to mkrasnitski/serenity
that referenced
this pull request
Jun 30, 2025
…ap tree (serenity-rs#3114) Avoid temporarily deserializing gateway messages to a `serde_json::Map<String, Value>` before typed deserialization to an `Event`. Previously, this meant the creation of a `serde_json::Value` tree, causing creation and immediately after the destruction of upwards of hundreds to thousands of owned strings and btreemaps for every handled gateway event.
mkrasnitski
added a commit
to mkrasnitski/serenity
that referenced
this pull request
Jun 30, 2025
Followup to serenity-rs#3114. By using an intermediate untagged enum with an `Unknown` variant, we can process sequence numbers for unknown events without cloning the json payload.
mkrasnitski
pushed a commit
to mkrasnitski/serenity
that referenced
this pull request
Jun 30, 2025
…ap tree (serenity-rs#3114) Avoid temporarily deserializing gateway messages to a `serde_json::Map<String, Value>` before typed deserialization to an `Event`. Previously, this meant the creation of a `serde_json::Value` tree, causing creation and immediately after the destruction of upwards of hundreds to thousands of owned strings and btreemaps for every handled gateway event.
mkrasnitski
added a commit
to mkrasnitski/serenity
that referenced
this pull request
Jun 30, 2025
Followup to serenity-rs#3114. By using an intermediate untagged enum with an `Unknown` variant, we can process sequence numbers for unknown events without cloning the json payload.
mkrasnitski
pushed a commit
to mkrasnitski/serenity
that referenced
this pull request
Jul 28, 2025
…ap tree (serenity-rs#3114) Avoid temporarily deserializing gateway messages to a `serde_json::Map<String, Value>` before typed deserialization to an `Event`. Previously, this meant the creation of a `serde_json::Value` tree, causing creation and immediately after the destruction of upwards of hundreds to thousands of owned strings and btreemaps for every handled gateway event.
mkrasnitski
added a commit
to mkrasnitski/serenity
that referenced
this pull request
Jul 28, 2025
Followup to serenity-rs#3114. By using an intermediate untagged enum with an `Unknown` variant, we can process sequence numbers for unknown events without cloning the json payload.
mkrasnitski
pushed a commit
to mkrasnitski/serenity
that referenced
this pull request
Jul 28, 2025
…ap tree (serenity-rs#3114) Avoid temporarily deserializing gateway messages to a `serde_json::Map<String, Value>` before typed deserialization to an `Event`. Previously, this meant the creation of a `serde_json::Value` tree, causing creation and immediately after the destruction of upwards of hundreds to thousands of owned strings and btreemaps for every handled gateway event.
mkrasnitski
added a commit
to mkrasnitski/serenity
that referenced
this pull request
Jul 28, 2025
Followup to serenity-rs#3114. By using an intermediate untagged enum with an `Unknown` variant, we can process sequence numbers for unknown events without cloning the json payload.
mkrasnitski
pushed a commit
to mkrasnitski/serenity
that referenced
this pull request
Oct 7, 2025
…ap tree (serenity-rs#3114) Avoid temporarily deserializing gateway messages to a `serde_json::Map<String, Value>` before typed deserialization to an `Event`. Previously, this meant the creation of a `serde_json::Value` tree, causing creation and immediately after the destruction of upwards of hundreds to thousands of owned strings and btreemaps for every handled gateway event.
mkrasnitski
added a commit
to mkrasnitski/serenity
that referenced
this pull request
Oct 7, 2025
Followup to serenity-rs#3114. By using an intermediate untagged enum with an `Unknown` variant, we can process sequence numbers for unknown events without cloning the json payload.
mkrasnitski
pushed a commit
to mkrasnitski/serenity
that referenced
this pull request
Oct 7, 2025
…ap tree (serenity-rs#3114) Avoid temporarily deserializing gateway messages to a `serde_json::Map<String, Value>` before typed deserialization to an `Event`. Previously, this meant the creation of a `serde_json::Value` tree, causing creation and immediately after the destruction of upwards of hundreds to thousands of owned strings and btreemaps for every handled gateway event.
mkrasnitski
added a commit
to mkrasnitski/serenity
that referenced
this pull request
Oct 7, 2025
Followup to serenity-rs#3114. By using an intermediate untagged enum with an `Unknown` variant, we can process sequence numbers for unknown events without cloning the json payload.
mkrasnitski
pushed a commit
to mkrasnitski/serenity
that referenced
this pull request
Oct 7, 2025
…ap tree (serenity-rs#3114) Avoid temporarily deserializing gateway messages to a `serde_json::Map<String, Value>` before typed deserialization to an `Event`. Previously, this meant the creation of a `serde_json::Value` tree, causing creation and immediately after the destruction of upwards of hundreds to thousands of owned strings and btreemaps for every handled gateway event.
mkrasnitski
added a commit
to mkrasnitski/serenity
that referenced
this pull request
Oct 7, 2025
Followup to serenity-rs#3114. By using an intermediate untagged enum with an `Unknown` variant, we can process sequence numbers for unknown events without cloning the json payload.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid temporarily deserializing gateway messages to a
serde_json::Map<String, Value>before typed deserialization to anEvent. Previously, this meant the creation of a serde_json::Value tree, causing creation and immediately after the destruction of upwards of hundreds to thousands of owned strings and btreemaps for every handled gateway event.