update current application object struct#3041
Closed
ivinjabraham wants to merge 1 commit intoserenity-rs:nextfrom
Closed
update current application object struct#3041ivinjabraham wants to merge 1 commit intoserenity-rs:nextfrom
ivinjabraham wants to merge 1 commit intoserenity-rs:nextfrom
Conversation
ivinjabraham
force-pushed
the
update-current-application-info
branch
from
07699f6 to
5393a8b
Compare
jamesbt365
requested changes
Nov 15, 2024
Member
jamesbt365
left a comment
jamesbt365
left a comment
There was a problem hiding this comment.
You are changing public fields, so this is a breaking change. Breaking changes must target next.
ivinjabraham
force-pushed
the
update-current-application-info
branch
from
5393a8b to
92c23e1
Compare
Contributor
Author
|
Alright done, I'll rebase #3035 to |
ivinjabraham
force-pushed
the
update-current-application-info
branch
from
92c23e1 to
3cf7756
Compare
Contributor
Author
|
Closing this PR to keep everything contained in #3035 as requested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Application::CurrentApplicationInfois out of date from the official docs