Update `CurrentApplicationInfo` and add support for editing it by ivinjabraham · Pull Request #3035 · serenity-rs/serenity

ivinjabraham · 2024-11-13T20:21:03Z

jamesbt365

Use the provided to_vec function instead of importing it from serde_json.

jamesbt365 · 2024-11-13T20:28:14Z

Also you haven't added anything but the low level http interface? Http usually shouldn't be directly used and you should probably add a builder like how our other stuff interacts with http.

ivinjabraham · 2024-11-13T20:43:44Z

Use the provided to_vec function instead of importing it from serde_json.

Pesky auto-import. Should be fixed now.

Also you haven't added anything but the low level http interface? Http usually shouldn't be directly used and you should probably add a builder like how our other stuff interacts with http.

Right, so I'll make a edit_current_application_info.rs and impl Builder along with the required structs and methods?

ivinjabraham · 2024-11-15T09:16:47Z

It seems the CurrentApplicationInfo struct is out of date. There are few fields such as event_webhook_url and event_webhook_status that are missing. I'll send in a PR for that first.

Doc for reference

jamesbt365

edit_current_appllication_info.rs -> edit_current_application_info.rs

src/builder/edit_current_application_info.rs

src/model/application/mod.rs

src/builder/edit_current_application_info.rs

jamesbt365 · 2024-11-27T16:04:00Z

I think everything in CurrentApplicationInfo can use FixedString (String replacment) and FixedArray (Vec replacement)

This was missing on FullEvent but was present within the event itself.

Values are getting quite close to the u8 limit (193), so let's preemptively bump this to avoid future breaking changes.

Moves the feature-gated collector methods on `UserId`, `MessageId`, etc. into four traits: - `CollectMessages` - `CollectReactions` - `CollectModalInteractions` - `CollectComponentInteractions` This also moves the quick modal machinery into the collector module and defines a `QuickModal` trait. This fully removes any collector feature gates from the model types.

This file was removed from the module tree but never actually deleted.

Fixes CI failure

…rs#3075) Similar to message URLs, Discord also provides URLs for guild channels. Additionally, the function is added as an alternative for parsing a `Channel` from a string. Private channels are not affected by this change.

arqunis · 2024-12-26T19:47:55Z

src/builder/edit_current_application_info.rs

+    /// Icon for the app
+    pub fn icon(mut self, base64_image_data: String) -> Self {
+        self.icon = Some(base64_image_data);
+        self
+    }
+
+    /// Sets the default rich presence invite cover image using base64 image data.
+    pub fn cover_image(mut self, base64_image_data: String) -> Self {
+        self.cover_image = Some(base64_image_data);
+        self
+    }


Rather than passing in base64 data manually as a String, we should allow the user to decide the place they want to source the image from and convert it to base64 on their behalf, similar to how EditProfile::avatar does it using CreateAttachment.

arqunis · 2024-12-26T19:51:26Z

src/model/application/mod.rs

+    pub slug: FixedString,
    #[serde(default)]
-    pub cover_image: Option<FixedString>,
+    pub cover_image: FixedString,


Similar to the application icon, the API returns a hash of a constant size, so this should use ImageHash to store the hash inline. Also should be wrapped in an Option<...>.

GnomedDev · 2025-07-25T11:17:05Z

This PR looks to be idle and therefore I am closing it to clean up the PR list, if anyone wants to pick up this and resolve the existing review comments here feel free to open a new PR.

github-actions bot added the http Related to the `http` module. label Nov 13, 2024

ivinjabraham force-pushed the current branch from f298296 to 424af70 Compare November 13, 2024 20:21

jamesbt365 requested changes Nov 13, 2024

View reviewed changes

ivinjabraham force-pushed the current branch from 424af70 to 0cee4cc Compare November 13, 2024 20:29

ivinjabraham marked this pull request as draft November 13, 2024 20:34

ivinjabraham mentioned this pull request Nov 15, 2024

update current application object struct #3041

Closed

ivinjabraham changed the base branch from current to next November 15, 2024 15:09

ivinjabraham force-pushed the current branch 2 times, most recently from 5ba44d9 to 24ffd92 Compare November 15, 2024 15:45

GnomedDev force-pushed the next branch from 9296017 to efb5820 Compare November 15, 2024 19:29

ivinjabraham force-pushed the current branch from 24ffd92 to f2c1085 Compare November 17, 2024 12:24

github-actions bot added the model Related to the `model` module. label Nov 17, 2024

ivinjabraham force-pushed the current branch from 7f72d28 to 71ab298 Compare November 17, 2024 13:57

github-actions bot added the builder Related to the `builder` module. label Nov 17, 2024

ivinjabraham force-pushed the current branch 3 times, most recently from 20d45ab to 8fd6b7e Compare November 17, 2024 16:41

jamesbt365 requested changes Nov 17, 2024

View reviewed changes

ivinjabraham force-pushed the current branch 2 times, most recently from 8c6dd76 to 6a5d2a5 Compare November 17, 2024 18:04

ivinjabraham marked this pull request as ready for review November 18, 2024 03:43

ivinjabraham requested a review from jamesbt365 November 18, 2024 03:43

mkrasnitski reviewed Nov 20, 2024

View reviewed changes

src/builder/edit_current_application_info.rs Outdated Show resolved Hide resolved

ivinjabraham force-pushed the current branch from 6a5d2a5 to 8ed3e32 Compare November 20, 2024 17:44

GnomedDev requested changes Nov 20, 2024

View reviewed changes

src/model/application/mod.rs Outdated Show resolved Hide resolved

src/model/application/mod.rs Outdated Show resolved Hide resolved

src/builder/edit_current_application_info.rs Outdated Show resolved Hide resolved

ivinjabraham force-pushed the current branch from 8ed3e32 to 52057ba Compare November 27, 2024 15:59

arqunis and others added 8 commits December 8, 2024 13:23

Use correct token prefix after parsing

b6abcc1

Add guild_id to ReactionRemoveAll (serenity-rs#3058)

87f6039

This was missing on FullEvent but was present within the event itself.

Bump the discriminant of audit_log::Action to u16 (serenity-rs#3062)

885bd06

Values are getting quite close to the u8 limit (193), so let's preemptively bump this to avoid future breaking changes.

Fix transport compression feature & add CI tests (serenity-rs#3067)

6286c18

Remove unused json.rs file (serenity-rs#3071)

26fc4b2

This file was removed from the module tree but never actually deleted.

Fix clippy warning on next (serenity-rs#3078)

f7daa0f

Fixes CI failure

arqunis force-pushed the next branch from d7c5ee3 to 7e90b9d Compare December 8, 2024 18:51

ivinjabraham force-pushed the current branch from d05677b to a088f6e Compare December 9, 2024 14:37

mkrasnitski and others added 4 commits December 9, 2024 22:41

Fix clippy warning (serenity-rs#3081)

18d9582

add support for edit_current_application endpoint

3e26b47

update current application object struct

a74aa1c

add builder for edit_current_application_info endpoint

1b63edf

ivinjabraham force-pushed the current branch from a088f6e to 1b63edf Compare December 13, 2024 05:16

ivinjabraham requested review from GnomedDev and mkrasnitski December 13, 2024 05:21

arqunis requested changes Dec 26, 2024

View reviewed changes

arqunis changed the title ~~add support for edit_current_application endpoint~~ Update CurrentApplicationInfo and add support for editing it Dec 26, 2024

arqunis force-pushed the next branch from 5943323 to 5f07257 Compare January 16, 2025 20:57

arqunis force-pushed the next branch from e71723e to 872e19c Compare February 1, 2025 14:44

arqunis force-pushed the next branch from 55e6901 to 3923997 Compare February 14, 2025 18:46

arqunis force-pushed the next branch 2 times, most recently from 57c79ff to 9a811a7 Compare March 11, 2025 22:17

GnomedDev force-pushed the next branch from d29b7a6 to da271c8 Compare March 26, 2025 21:28

GnomedDev force-pushed the next branch from 6e9fe28 to 4a180eb Compare April 28, 2025 12:35

GnomedDev force-pushed the next branch from 956f5f1 to f085918 Compare May 19, 2025 20:26

arqunis force-pushed the next branch from 361e2fc to ffaf185 Compare June 30, 2025 17:17

GnomedDev closed this Jul 25, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update `CurrentApplicationInfo` and add support for editing it#3035

Update `CurrentApplicationInfo` and add support for editing it#3035
ivinjabraham wants to merge 171 commits intoserenity-rs:nextfrom
ivinjabraham:current

ivinjabraham commented Nov 13, 2024 •

edited

Loading

Uh oh!

jamesbt365 left a comment

Uh oh!

jamesbt365 commented Nov 13, 2024

Uh oh!

ivinjabraham commented Nov 13, 2024

Uh oh!

ivinjabraham commented Nov 15, 2024 •

edited

Loading

Uh oh!

jamesbt365 left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jamesbt365 commented Nov 27, 2024

Uh oh!

arqunis Dec 26, 2024

Uh oh!

arqunis Dec 26, 2024

Uh oh!

GnomedDev commented Jul 25, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

18 participants

Conversation

ivinjabraham commented Nov 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jamesbt365 left a comment

Choose a reason for hiding this comment

Uh oh!

jamesbt365 commented Nov 13, 2024

Uh oh!

ivinjabraham commented Nov 13, 2024

Uh oh!

ivinjabraham commented Nov 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jamesbt365 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jamesbt365 commented Nov 27, 2024

Uh oh!

arqunis Dec 26, 2024

Choose a reason for hiding this comment

Uh oh!

arqunis Dec 26, 2024

Choose a reason for hiding this comment

Uh oh!

GnomedDev commented Jul 25, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

18 participants

ivinjabraham commented Nov 13, 2024 •

edited

Loading

ivinjabraham commented Nov 15, 2024 •

edited

Loading