-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add assertTrueAboutPromise() and assertFalseAboutPromise() #21
Merged
Merged
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
78f9cc3
Added new assertions
ace411 a338f3e
Added assertion docs
ace411 48503f1
Added assertion docs
ace411 583b5d9
Merge branch 'assertions'
ace411 a5a2f7d
Applied style fixes
ace411 f0a2e3b
Merge branch 'master' into ace411-master
seregazhuk f302c92
Move assertions to trait
seregazhuk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,68 @@ | ||
<?php | ||
|
||
namespace seregazhuk\React\PromiseTesting\tests; | ||
|
||
use Exception; | ||
use React\Promise\Deferred; | ||
use seregazhuk\React\PromiseTesting\TestCase; | ||
|
||
final class AboutPromiseTest extends TestCase | ||
{ | ||
/** @test */ | ||
public function predicate_function_reveals_what_is_true_about_promise(): void | ||
{ | ||
try { | ||
$fst = new Deferred; | ||
$fst->resolve(23); | ||
|
||
$snd = new Deferred; | ||
$snd->reject(new Exception('An error')); | ||
|
||
$thd = new Deferred; | ||
$thd->reject('Another error'); | ||
|
||
$this->assertTrueAboutPromise($fst->promise(), function ($val): bool { | ||
return is_int($val) && $val > 20; | ||
}); | ||
$this->assertTrueAboutPromise($fst->promise(), 'is_string'); | ||
|
||
$this->assertTrueAboutPromise($snd->promise(), 'is_string'); | ||
|
||
$this->assertTrueAboutPromise($thd->promise(), 'is_string'); | ||
} catch (Exception $exception) { | ||
$this->assertRegExp( | ||
'/Failed asserting that .+/', | ||
$exception->getMessage() | ||
); | ||
} | ||
} | ||
|
||
/** @test */ | ||
public function predicate_function_reveals_what_is_false_about_promise(): void | ||
{ | ||
try { | ||
$fst = new Deferred; | ||
$fst->resolve(23); | ||
|
||
$snd = new Deferred; | ||
$snd->reject(new Exception('An error')); | ||
|
||
$thd = new Deferred; | ||
$thd->reject('Another error'); | ||
|
||
$this->assertFalseAboutPromise($fst->promise(), function ($val): bool { | ||
return is_int($val) && $val > 20; | ||
}); | ||
$this->assertFalseAboutPromise($fst->promise(), 'is_string'); | ||
|
||
$this->assertFalseAboutPromise($snd->promise(), 'is_string'); | ||
|
||
$this->assertFalseAboutPromise($thd->promise(), 'is_int'); | ||
} catch (Exception $exception) { | ||
$this->assertRegExp( | ||
'/Failed asserting that .+/', | ||
$exception->getMessage() | ||
); | ||
} | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you used tabs instead of spaces here. Can you fix it, please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I will. Thanks for responding.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this look better? a5a2f7d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! 🔥 There is a conflict with master branch. Can you fix it? and I'll merge the request.