Add assertTrueAboutPromise() and assertFalseAboutPromise() #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seregazhuk
approved these changes
Jun 19, 2020
tests/AboutPromiseTest.php
Outdated
| final class AboutPromiseTest extends TestCase | ||
| { | ||
| /** @test */ | ||
| public function predicate_function_reveals_what_is_true_about_promise(): void |
There was a problem hiding this comment.
Looks like you used tabs instead of spaces here. Can you fix it, please?
There was a problem hiding this comment.
Yes, I will. Thanks for responding.
There was a problem hiding this comment.
Does this look better? a5a2f7d
There was a problem hiding this comment.
Looks great! 🔥 There is a conflict with master branch. Can you fix it? and I'll merge the request.
# Conflicts: # src/TestCase.php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear maintainer,
I kindly request that you add the
assertTrueAboutPromise()andassertFalseAboutPromise()test assertions to the library as I believe they are helpful in performing a vastness of checks on values subsumed in promises.