Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: specify node-selector and service-account (#118) #119

Conversation

jorgeaguileraseqera
Copy link
Contributor

closes #118

Signed-off-by: Jorge Aguilera [email protected]

@jorgeaguileraseqera jorgeaguileraseqera self-assigned this Sep 8, 2022
Copy link
Collaborator

@pditommaso pditommaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, made a few comments

service account as optional

Signed-off-by: Jorge Aguilera <[email protected]>
Copy link
Collaborator

@pditommaso pditommaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@pditommaso pditommaso merged commit d93b0cc into master Sep 8, 2022
@pditommaso pditommaso deleted the 118-add-support-for-nodeselector-and-service-account-to-k8s-build-pod branch September 8, 2022 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for NodeSelector and Service Account to K8s build pod
2 participants