Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for NodeSelector and Service Account to K8s build pod #118

Closed
pditommaso opened this issue Sep 7, 2022 · 0 comments · Fixed by #119
Closed

Add support for NodeSelector and Service Account to K8s build pod #118

pditommaso opened this issue Sep 7, 2022 · 0 comments · Fixed by #119

Comments

@pditommaso
Copy link
Collaborator

It required to add the support for custom nodeSelector and serviceAccount for the K8s builder pod.

Setting are going to be

wave.build.k8s.nodeSelector: <MAP>
wave.build.k8s.serviceAccount: <STRING>

https://kubernetes.io/docs/tasks/configure-pod-container/assign-pods-nodes/#create-a-pod-that-gets-scheduled-to-your-chosen-node

https://kubernetes.io/docs/tasks/configure-pod-container/configure-service-account/
@jorgeaguileraseqera jorgeaguileraseqera self-assigned this Sep 7, 2022
jorgeaguileraseqera added a commit that referenced this issue Sep 7, 2022
@jorgeaguileraseqera
feature: specify node-selector and service-account (#118)
760e3bb 
Signed-off-by: Jorge Aguilera <[email protected]>
@jorgeaguileraseqera jorgeaguileraseqera mentioned this issue Sep 8, 2022
Merged
jorgeaguileraseqera added a commit that referenced this issue Sep 8, 2022
@jorgeaguileraseqera
feature: specify node-selector and service-account (#118)
47b45e4 
service account as optional

Signed-off-by: Jorge Aguilera <[email protected]>
pditommaso pushed a commit that referenced this issue Sep 8, 2022
@jorgeaguileraseqera
feature: specify node-selector and service-account (#118) (#119)
d93b0cc 

Signed-off-by: Jorge Aguilera <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feature: specify node-selector and service-account (#118) seqeralabs/wave
2 participants
@pditommaso @jorgeaguileraseqera