-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Seqera containers: POC 4 #46
base: main
Are you sure you want to change the base?
Conversation
Perfect 👌 |
When preparing my Bytesize talk about I was more thinking along the line that This has two advantages:
On the other hand, this also has two downsides:
Along this line, something puzzles me with your proposed POC here: If one heeds the red Danger box in the Nextflow docs that reads "When using the profiles feature in your config file, do NOT set attributes in the same scope both inside and outside a profiles context", your proposed solution here would basically block the |
That danger box is essentially a bug in the config parser that will be fixed by the new (strict) config parser (nextflow-io/nextflow#4744). So we might need to merge that feature first, although to be honest, I have never been able to reproduce that bug consistently, it seems to happen only in very specific cases. |
Seqera Containers: Proof of concept No. 4
Hardcode container URIs at module level - in a config file
Note
Only works here because this pipeline is already importing the module-level
nextflow.config
files here:nf-aggregate/workflows/nf_aggregate/nextflow.config
Lines 1 to 3 in 496dba5
Flow is as follows:
nextflow.config
workflows/nf_aggregate/nextflow.config
modules/***/***/nextflow.config
Workflow for generating:
nextflow inspect
commands to regenerate module-level config files with pinned container namesincludeConfig
statements for module-level config file.Workflow for usage: (same as current except different profile names)
nextflow run -profile docker
ordocker,docker_arm
,singularity,singularity_arm
nf-core download
as done currently, may need some kind of profile change, not sure.Put the config into separated files at module level to keep them out of the way.
main.nf