-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Seqera containers: POC 1 #43
Open
ewels
wants to merge
7
commits into
seqeralabs:main
Choose a base branch
from
ewels:seqera_containers_poc_1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IMO, config generation should be done at the pipeline level. |
Yup, in this one it is pipeline level 👍🏻 Updated the PR comment a little to make this clearer. |
Understand. I was confused by the |
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seqera Containers: Proof of concept No. 1
Hardcode container URIs at pipeline level.
Workflow for generating:
nextflow inspect
commands to regenerate pipeline-level config files with pinned container namesWorkflow for usage: (same as current except different profile names)
nextflow run -profile seqera_containers_docker
(profile names up for refinement). Add profilessingularity
and/orarm
as required.nf-core download
as done currently, may need some kind of profile change, not sure.Put the config into separated files at pipeline level to keep them out of the way.
Added comments at the top of the files mentioning that it's auto-generated, along with the command used.