Skip to content

update tests that were only running on .net 9#371

Merged
sensslen merged 1 commit into
mainfrom
simon/update-dotnet-used
Dec 19, 2025
Merged

update tests that were only running on .net 9#371
sensslen merged 1 commit into
mainfrom
simon/update-dotnet-used

Conversation

@sensslen
Copy link
Copy Markdown
Owner

@sensslen sensslen commented Dec 19, 2025

Summary by CodeRabbit

  • Chores
    • Updated test projects to target .NET 10.0 instead of .NET 9.0
    • Updated build workflow to support .NET 8.0.x and 10.0.x, removing .NET 9.0.x support

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Dec 19, 2025

Walkthrough

This pull request removes .NET 9.0.x references from GitHub Actions workflow steps, narrowing supported .NET versions to 8.0.x and 10.0.x in those jobs. Additionally, two test project files are updated to target .NET 10.0 instead of .NET 9.0: FileLicenseMatcher.Test.csproj and NuGetUtility.UrlToLicenseMapping.Test.csproj. No other functional changes or error-handling logic modifications are introduced.

Possibly related PRs

Pre-merge checks and finishing touches

✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main changes: updating test target frameworks from .NET 9.0 to .NET 10.0, which directly addresses the issue of tests that were limited to running on .NET 9.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch simon/update-dotnet-used

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c98a6f5 and 220a891.

📒 Files selected for processing (3)
  • .github/workflows/action.yml (0 hunks)
  • tests/FileLicenseMatcher.Test/FileLicenseMatcher.Test.csproj (1 hunks)
  • tests/NuGetUtility.UrlToLicenseMapping.Test/NuGetUtility.UrlToLicenseMapping.Test.csproj (1 hunks)
💤 Files with no reviewable changes (1)
  • .github/workflows/action.yml
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: sensslen
Repo: sensslen/nuget-license PR: 327
File: .github/workflows/release.yml:38-38
Timestamp: 2025-11-07T21:33:27.230Z
Learning: In the release workflow (.github/workflows/release.yml), the test assembly pattern `NuGet*.Test.dll` intentionally excludes SPDXLicenseMatcher.Test.dll from the release workflow tests.
📚 Learning: 2025-11-07T21:33:27.230Z
Learnt from: sensslen
Repo: sensslen/nuget-license PR: 327
File: .github/workflows/release.yml:38-38
Timestamp: 2025-11-07T21:33:27.230Z
Learning: In the release workflow (.github/workflows/release.yml), the test assembly pattern `NuGet*.Test.dll` intentionally excludes SPDXLicenseMatcher.Test.dll from the release workflow tests.

Applied to files:

  • tests/FileLicenseMatcher.Test/FileLicenseMatcher.Test.csproj
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (18)
  • GitHub Check: check_licenses (net10.0, ProjectWithReferenceContainingFileLicense)
  • GitHub Check: check_licenses (net9.0, ProjectWithReferenceContainingLicenseExpression)
  • GitHub Check: check_licenses (net8.0, App)
  • GitHub Check: check_licenses_net472 (Tests)
  • GitHub Check: check_licenses_net472 (ProjectWithReferenceContainingFileLicense)
  • GitHub Check: test (ubuntu-latest, net10.0)
  • GitHub Check: check_licenses_net472 (ProjectWithReferenceContainingWindowsSpecificPath)
  • GitHub Check: test (macos-latest, net8.0)
  • GitHub Check: check_licenses_net472 (App)
  • GitHub Check: test (macos-latest, net9.0)
  • GitHub Check: check_version_command (net10.0)
  • GitHub Check: test_windows (net10.0)
  • GitHub Check: test_windows (net9.0)
  • GitHub Check: test_file_license_matching (windows-latest)
  • GitHub Check: test_windows (net8.0)
  • GitHub Check: test_windows (net472)
  • GitHub Check: test_file_license_matching (ubuntu-latest)
  • GitHub Check: test_file_license_matching (macos-latest)
🔇 Additional comments (2)
tests/NuGetUtility.UrlToLicenseMapping.Test/NuGetUtility.UrlToLicenseMapping.Test.csproj (1)

4-4: Framework update aligns with test migration strategy.

The update from net9.0 to net10.0 is consistent with the other test project changes in this PR. Please ensure the same verification steps mentioned in FileLicenseMatcher.Test.csproj apply here regarding .NET 10.0 availability and package compatibility.

tests/FileLicenseMatcher.Test/FileLicenseMatcher.Test.csproj (1)

4-4: No action required. Dot.NET 10.0 was officially released on November 11, 2025 and is the next Long-Term Support (LTS) release with three years of official support. Microsoft.NET.Test.Sdk 18.0.1 exists, and it was specifically designed to fix an issue with loading covrun64.dll on systems that have .NET 10 SDK installed, confirming full compatibility with net10.0.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link
Copy Markdown

@sensslen sensslen merged commit e1bf9e2 into main Dec 19, 2025
80 of 81 checks passed
@sensslen sensslen deleted the simon/update-dotnet-used branch December 19, 2025 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant