Skip to content

update to release .net10#336

Merged
sensslen merged 1 commit into
mainfrom
simon/update-to-release-.net-10
Nov 12, 2025
Merged

update to release .net10#336
sensslen merged 1 commit into
mainfrom
simon/update-to-release-.net-10

Conversation

@sensslen
Copy link
Copy Markdown
Owner

@sensslen sensslen commented Nov 12, 2025

Summary by CodeRabbit

  • Chores
    • Updated SDK from release candidate to stable version.
    • Updated multiple package dependencies to newer versions for improved compatibility and stability.
    • Refreshed test infrastructure dependencies across test projects.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Nov 12, 2025

Walkthrough

This pull request updates dependencies and SDK configuration across the solution. The .NET SDK version in global.json is updated from a release candidate (10.0.100-rc.2.25502.107) to the stable release (10.0.100), with the rollForward policy changed from "latestMajor" to "latestMinor". NuGet packages in source projects are updated: NuGet.Commands and NuGet.Packaging from 6.14.0 to 7.0.0 in NuGetUtility, while System.IO.Hashing and System.Collections.Immutable are bumped from 9.0.10 to 10.0.0 for net472 targets. Test projects receive incremental updates to testing infrastructure packages: Microsoft.NET.Test.Sdk 18.0.0 to 18.0.1, Verify packages from 31.4.3 to 31.6.0, and TUnit from 1.0.0 to 1.0.78.

Possibly related PRs

  • PR #325: Updates global.json's SDK version and rollForward configuration, same files and properties modified in this PR.
  • PR #327: Addresses renaming and workflow fixes for the NuGetUtility.UrlToLicenseMapping.Test project that receives dependency updates in this PR.

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The PR title mentions '.net10' but the actual changes focus on updating dependencies (NuGet packages, SDK version, framework-specific libraries) rather than upgrading the project to .NET 10. Clarify whether this PR upgrades the target framework to .NET 10 or simply updates dependencies for .NET 10 compatibility. If it's a dependency update, consider a more descriptive title like 'Update dependencies for .NET 10 compatibility' or 'Bump NuGet packages and system libraries'.
✅ Passed checks (1 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch simon/update-to-release-.net-10

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between eb78bbe and 247b24f.

📒 Files selected for processing (7)
  • global.json (1 hunks)
  • src/NuGetLicense/NuGetLicense.csproj (1 hunks)
  • src/NuGetUtility/NuGetUtility.csproj (2 hunks)
  • tests/NuGetLicense.Test/NuGetLicense.Test.csproj (1 hunks)
  • tests/NuGetUtility.Test/NuGetUtility.Test.csproj (1 hunks)
  • tests/NuGetUtility.UrlToLicenseMapping.Test/NuGetUtility.UrlToLicenseMapping.Test.csproj (1 hunks)
  • tests/SPDXLicenseMatcher.Test/SPDXLicenseMatcher.Test.csproj (1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-11-07T21:33:27.152Z
Learnt from: sensslen
Repo: sensslen/nuget-license PR: 327
File: .github/workflows/release.yml:38-38
Timestamp: 2025-11-07T21:33:27.152Z
Learning: In the release workflow (.github/workflows/release.yml), the test assembly pattern `NuGet*.Test.dll` intentionally excludes SPDXLicenseMatcher.Test.dll from the release workflow tests.

Applied to files:

  • tests/NuGetLicense.Test/NuGetLicense.Test.csproj
  • tests/SPDXLicenseMatcher.Test/SPDXLicenseMatcher.Test.csproj
  • tests/NuGetUtility.UrlToLicenseMapping.Test/NuGetUtility.UrlToLicenseMapping.Test.csproj
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (20)
  • GitHub Check: check_licenses (net10.0, App)
  • GitHub Check: check_licenses (net9.0, Tests)
  • GitHub Check: check_licenses (net8.0, App)
  • GitHub Check: check_licenses (net8.0, Tests)
  • GitHub Check: check_licenses (net9.0, ProjectWithReferenceContainingFileLicense)
  • GitHub Check: test_windows (net8.0)
  • GitHub Check: test_windows (net9.0)
  • GitHub Check: test_windows (net10.0)
  • GitHub Check: check_licenses_net472 (ProjectWithReferenceContainingLicenseExpression)
  • GitHub Check: test_windows (net472)
  • GitHub Check: check_licenses_net472 (ProjectWithReferenceContainingFileLicense)
  • GitHub Check: check_licenses_net472 (App)
  • GitHub Check: check_licenses_net472 (Tests)
  • GitHub Check: test (macos-latest, net10.0)
  • GitHub Check: check_version_command_net472
  • GitHub Check: test (macos-latest, net8.0)
  • GitHub Check: test (ubuntu-latest, net8.0)
  • GitHub Check: test_file_license_matching (windows-latest)
  • GitHub Check: test_file_license_matching (ubuntu-latest)
  • GitHub Check: test_file_license_matching (macos-latest)
🔇 Additional comments (8)
global.json (1)

6-7: Verify the rollForward policy change.

The change from "latestMajor" to "latestMinor" restricts SDK updates to minor/patch versions within the current major version. This is more conservative, but ensure it aligns with your project's stability goals and won't require manual SDK version updates in the future.

tests/NuGetUtility.UrlToLicenseMapping.Test/NuGetUtility.UrlToLicenseMapping.Test.csproj (1)

17-25: Test framework updates look reasonable.

Patch and minor version updates to test SDKs and Verify are routine. The TUnit jump (1.0.0 → 1.0.78) reflects a version stabilization that should be compatible with existing tests.

Ensure all tests pass with TUnit 1.0.78 to confirm compatibility with the existing test suite.

tests/NuGetUtility.Test/NuGetUtility.Test.csproj (1)

23-31: Consistent test infrastructure updates.

Patch and minor version updates align with the broader test tooling improvements across the solution. Multi-target configuration (net472/net8.0/net9.0/net10.0) is well-supported by these versions.

tests/NuGetLicense.Test/NuGetLicense.Test.csproj (1)

23-31: Consistent with test infrastructure updates across the solution.

Routine patch and minor version bumps for test SDKs and verification tooling.

tests/SPDXLicenseMatcher.Test/SPDXLicenseMatcher.Test.csproj (1)

17-23: Test framework updates are consistent with other TUnit-based test projects.

Patch, pre-release stabilization (TUnit 1.0.0 → 1.0.78), and minor version updates follow the PR's overall pattern.

src/NuGetLicense/NuGetLicense.csproj (1)

24-26: System library updates for net472 compatibility are appropriate.

Bumping System.IO.Hashing and System.Collections.Immutable to 10.0.0 for the net472 target ensures proper compatibility with the .NET 10 ecosystem while maintaining legacy framework support.

src/NuGetUtility/NuGetUtility.csproj (2)

23-24: Verify NuGet package compatibility after major version bump.

The jump from NuGet.Commands and NuGet.Packaging 6.14.0 to 7.0.0 is a major version change that could introduce breaking API changes. This is a critical update for a utility library that likely depends on NuGet APIs.

Confirm that the codebase has been tested with NuGet 7.0.0 and that all NuGet API calls are compatible with the new major version. If tests are passing, this indicates compatibility, but explicitly verify any NuGet API usage in the codebase.


40-42: System library updates for net472 follow consistent pattern.

System.IO.Hashing and System.Collections.Immutable updates to 10.0.0 align with the broader .NET 10 ecosystem and the net472 compatibility approach used elsewhere in the solution.


Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link
Copy Markdown

@sensslen sensslen merged commit 020291d into main Nov 12, 2025
38 checks passed
@sensslen sensslen deleted the simon/update-to-release-.net-10 branch November 12, 2025 14:15
@coderabbitai coderabbitai Bot mentioned this pull request May 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant