Skip to content

enable reproducible builds in CI for publishing#343

Merged
sensslen merged 2 commits into
mainfrom
simon/enable-reproducible-builds-in-CI
Nov 24, 2025
Merged

enable reproducible builds in CI for publishing#343
sensslen merged 2 commits into
mainfrom
simon/enable-reproducible-builds-in-CI

Conversation

@sensslen
Copy link
Copy Markdown
Owner

@sensslen sensslen commented Nov 24, 2025

Summary by CodeRabbit

  • Chores
    • Enabled CI build mode during packaging and publishing to ensure consistent compilation and packaging behavior across all release builds.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Nov 24, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

This change updates the GitHub Actions release workflow to add the MSBuild property -p:ContinuousIntegrationBuild=true to packaging commands. The flag is appended to dotnet publish invocations for net8, net9, and net10, to the msbuild invocation for net472, and to dotnet pack calls, causing those publish/pack steps to run with the Continuous Integration build flag set.

Possibly related PRs

  • sensslen/nuget-license PR 343 — modifies the same .github/workflows/release.yml to add -p:ContinuousIntegrationBuild=true to equivalent publish/pack commands.

Pre-merge checks and finishing touches

✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'enable reproducible builds in CI for publishing' directly and clearly describes the main change: adding -p:ContinuousIntegrationBuild=true flag to build commands for CI environments.

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3feef0b and 3e5c3ac.

📒 Files selected for processing (1)
  • .github/workflows/release.yml (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2c8706e and 3feef0b.

📒 Files selected for processing (1)
  • .github/workflows/release.yml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (20)
  • GitHub Check: check_licenses (net9.0, App)
  • GitHub Check: check_licenses (net10.0, App)
  • GitHub Check: check_licenses (net10.0, ProjectWithReferenceContainingFileLicense)
  • GitHub Check: check_licenses (net8.0, ProjectWithReferenceContainingFileLicense)
  • GitHub Check: check_licenses (net8.0, Tests)
  • GitHub Check: check_licenses (net8.0, App)
  • GitHub Check: check_licenses_net472 (ProjectWithReferenceContainingFileLicense)
  • GitHub Check: test_windows (net9.0)
  • GitHub Check: test_windows (net8.0)
  • GitHub Check: check_code_format
  • GitHub Check: test_windows (net472)
  • GitHub Check: check_licenses_net472 (Tests)
  • GitHub Check: test_windows (net10.0)
  • GitHub Check: test (macos-latest, net10.0)
  • GitHub Check: test (macos-latest, net9.0)
  • GitHub Check: check_version_command_net472
  • GitHub Check: test (macos-latest, net8.0)
  • GitHub Check: test_file_license_matching (windows-latest)
  • GitHub Check: test_file_license_matching (macos-latest)
  • GitHub Check: test_file_license_matching (ubuntu-latest)
🔇 Additional comments (1)
.github/workflows/release.yml (1)

51-57: ✓ Reproducible build flag correctly applied to publish/build steps.

The -p:ContinuousIntegrationBuild=true flag is properly added to all binary publishing steps for .NET 8, 9, and 10 using dotnet syntax (-p:), and to the .NET Framework 4.7.2 build using msbuild syntax (/p:). The flag placement and formatting are correct.

Comment thread .github/workflows/release.yml Outdated
@sensslen sensslen merged commit 90466ff into main Nov 24, 2025
35 of 36 checks passed
@sensslen sensslen deleted the simon/enable-reproducible-builds-in-CI branch November 24, 2025 10:26
@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant