enable reproducible builds in CI for publishing#343
Conversation
|
Caution Review failedThe pull request is closed. WalkthroughThis change updates the GitHub Actions release workflow to add the MSBuild property Possibly related PRs
Pre-merge checks and finishing touches✅ Passed checks (2 passed)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/release.yml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (20)
- GitHub Check: check_licenses (net9.0, App)
- GitHub Check: check_licenses (net10.0, App)
- GitHub Check: check_licenses (net10.0, ProjectWithReferenceContainingFileLicense)
- GitHub Check: check_licenses (net8.0, ProjectWithReferenceContainingFileLicense)
- GitHub Check: check_licenses (net8.0, Tests)
- GitHub Check: check_licenses (net8.0, App)
- GitHub Check: check_licenses_net472 (ProjectWithReferenceContainingFileLicense)
- GitHub Check: test_windows (net9.0)
- GitHub Check: test_windows (net8.0)
- GitHub Check: check_code_format
- GitHub Check: test_windows (net472)
- GitHub Check: check_licenses_net472 (Tests)
- GitHub Check: test_windows (net10.0)
- GitHub Check: test (macos-latest, net10.0)
- GitHub Check: test (macos-latest, net9.0)
- GitHub Check: check_version_command_net472
- GitHub Check: test (macos-latest, net8.0)
- GitHub Check: test_file_license_matching (windows-latest)
- GitHub Check: test_file_license_matching (macos-latest)
- GitHub Check: test_file_license_matching (ubuntu-latest)
🔇 Additional comments (1)
.github/workflows/release.yml (1)
51-57: ✓ Reproducible build flag correctly applied to publish/build steps.The
-p:ContinuousIntegrationBuild=trueflag is properly added to all binary publishing steps for .NET 8, 9, and 10 using dotnet syntax (-p:), and to the .NET Framework 4.7.2 build using msbuild syntax (/p:). The flag placement and formatting are correct.
|



Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.