fix ci#470
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughThe pull request updates GitHub Actions workflow files (.github/workflows/action.yml and .github/workflows/release.yml) to replace occurrences of the runner label 🚥 Pre-merge checks | ✅ 1 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip You can get early access to new features in CodeRabbit.Enable the |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.github/workflows/release.yml (1)
67-68:⚠️ Potential issue | 🟠 Major
msbuildon line 68 should initialize the VS environment to ensure it's available.Line 68 runs
msbuildin the default PowerShell shell without re-initializing the VS developer environment. While the Chocolatey installation (lines 27-33) should add MSBuild to the system PATH, this approach is fragile and may fail if the package doesn't properly register the tools in the system PATH.Since line 44 already demonstrates the correct pattern with
shell: cmdand VsDevCmd.bat initialization, line 68 should follow the same approach:Proposed fix
- name: Publish the application binaries (.net472) + shell: cmd run: | + call "C:\Program Files\Microsoft Visual Studio\2026\BuildTools\Common7\Tools\VsDevCmd.bat" msbuild ./src/NuGetLicenseFramework/NuGetLicenseFramework.csproj /t:Publish /p:configuration=Release /p:PublishDir=${{ steps.artifacts_path.outputs.path }}/net472 /p:Version=${{ steps.version.outputs.full_without_prefix }} /p:ContinuousIntegrationBuild=true🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/release.yml around lines 67 - 68, The msbuild step currently runs msbuild directly in PowerShell (the msbuild command invocation) without initializing the Visual Studio developer environment; change the step to use the same pattern as the earlier step that calls VsDevCmd.bat (i.e., switch the step to run under shell: cmd and wrap the msbuild invocation with a call to the Visual Studio developer command script such as "call \"%ProgramFiles(x86)%\\Microsoft Visual Studio\\2019\\Enterprise\\Common7\\Tools\\VsDevCmd.bat\" && msbuild ...") so that the VS environment is initialized before invoking msbuild for the NuGetLicenseFramework.csproj publish.
🧹 Nitpick comments (1)
.github/workflows/action.yml (1)
270-277: Stale comment - refers to "build" but this is a restore step.The inline comment
:: Execute the build with the exact parameters from your failing runappears to be copy-pasted from the build step. Consider updating it for clarity.✏️ Suggested fix
- name: restore nuget packages shell: cmd run: | :: Initialize the VS 2026 Developer Command Prompt to load the correct paths call "C:\Program Files\Microsoft Visual Studio\2026\BuildTools\Common7\Tools\VsDevCmd.bat" - :: Execute the build with the exact parameters from your failing run + :: Restore NuGet packages msbuild -t:restore -p:RestorePackagesConfig=true NuGetUtility.sln🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/action.yml around lines 270 - 277, The inline comment in the "restore nuget packages" step is misleadingly saying "Execute the build"; update that comment to reflect that this step runs a NuGet restore. Locate the step with name "restore nuget packages" and replace the comment `:: Execute the build with the exact parameters from your failing run` with a clearer message such as `:: Execute the restore with the exact parameters from your failing run` (or similar) so it accurately describes the msbuild -t:restore invocation.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/action.yml:
- Around line 287-294: The MSBuild invocation in the check_licenses_net472 job
uses an undefined step output `${{ steps.version.outputs.version }}` so the
Version property will be empty; either add a version step (e.g., include the
paulhatch/semantic-version action with id: version before the msbuild run so
`steps.version.outputs.version` is populated) or remove the `/p:Version=${{
steps.version.outputs.version }}` parameter from the msbuild command in the
check_licenses_net472 job to avoid passing an empty value; update the job
accordingly and ensure the step id remains `version` if other references depend
on it.
---
Outside diff comments:
In @.github/workflows/release.yml:
- Around line 67-68: The msbuild step currently runs msbuild directly in
PowerShell (the msbuild command invocation) without initializing the Visual
Studio developer environment; change the step to use the same pattern as the
earlier step that calls VsDevCmd.bat (i.e., switch the step to run under shell:
cmd and wrap the msbuild invocation with a call to the Visual Studio developer
command script such as "call \"%ProgramFiles(x86)%\\Microsoft Visual
Studio\\2019\\Enterprise\\Common7\\Tools\\VsDevCmd.bat\" && msbuild ...") so
that the VS environment is initialized before invoking msbuild for the
NuGetLicenseFramework.csproj publish.
---
Nitpick comments:
In @.github/workflows/action.yml:
- Around line 270-277: The inline comment in the "restore nuget packages" step
is misleadingly saying "Execute the build"; update that comment to reflect that
this step runs a NuGet restore. Locate the step with name "restore nuget
packages" and replace the comment `:: Execute the build with the exact
parameters from your failing run` with a clearer message such as `:: Execute the
restore with the exact parameters from your failing run` (or similar) so it
accurately describes the msbuild -t:restore invocation.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 0a60b436-00fc-4a58-9dc2-e1baa06d524b
📒 Files selected for processing (2)
.github/workflows/action.yml.github/workflows/release.yml
|
1 participant
Summary by CodeRabbit