Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed link in README.md #633

Closed
wants to merge 1 commit into from
Closed

Fixed link in README.md #633

wants to merge 1 commit into from

Conversation

vinayak42
Copy link
Contributor

@vinayak42 vinayak42 commented Oct 4, 2018 •
edited
Loading

Fixed link for mail_example at line 87

Fixes

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • Fixed a link of a mail_example at line 87 of README.md

If you have questions, please send an email to SendGrid, or file a GitHub Issue in this repository.

@vinayak42
Fixed link in README.md
ef417f9 
Fixed link for mail_example at line 87
@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 4, 2018
@SendGridDX
Copy link

SendGridDX commented Oct 4, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Oct 4, 2018 •
edited
Loading

Codecov Report

Merging #633 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #633   +/-   ##
=======================================
  Coverage   84.77%   84.77%           
=======================================
  Files          35       35           
  Lines        1156     1156           
  Branches      172      172           
=======================================
  Hits          980      980           
  Misses         90       90           
  Partials       86       86

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f132e5b...ef417f9. Read the comment docs.

@misterdorm misterdorm added status: work in progress Twilio or the community is in the process of implementing difficulty: easy fix is easy in difficulty and removed status: code review request requesting a community code review or review from Twilio labels Oct 11, 2018
misterdorm
misterdorm requested changes Oct 11, 2018
View reviewed changes
README.md
@@ -84,7 +84,7 @@ pip install sendgrid

## Hello Email

The following is the minimum needed code to send an email with the [/mail/send Helper](https://github.com/sendgrid/sendgrid-python/tree/master/sendgrid/helpers/mail) ([here](https://github.com/sendgrid/sendgrid-python/blob/master/examples/helpers/mail/mail_example.py#L20) is a full example):
The following is the minimum needed code to send an email with the [/mail/send Helper](https://github.com/sendgrid/sendgrid-python/tree/master/sendgrid/helpers/mail) ([here](https://github.com/sendgrid/sendgrid-python/blob/master/examples/helpers/mail_example.py#L20) is a full example):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please update the link to go to the new line number mail_example.py#L9 instead, and also update the [/mail/send Helper] link on this line? Thanks.

@misterdorm misterdorm mentioned this pull request Oct 11, 2018
Merged
6 tasks
@vinayak42 vinayak42 mentioned this pull request Oct 16, 2018
Merged
6 tasks
@thinkingserious thinkingserious added hacktoberfest status: waiting for feedback waiting for feedback from the submitter type: docs update documentation change not affecting the code and removed status: work in progress Twilio or the community is in the process of implementing labels Oct 23, 2018
@thinkingserious
Copy link
Contributor

Hello @vinayak42,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@childish-sambino childish-sambino added status: duplicate duplicate issue and removed difficulty: easy fix is easy in difficulty hacktoberfest status: waiting for feedback waiting for feedback from the submitter type: docs update documentation change not affecting the code labels Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@misterdorm misterdorm misterdorm requested changes

Assignees
No one assigned
Labels
status: duplicate duplicate issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vinayak42 @SendGridDX @thinkingserious @misterdorm @childish-sambino