Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Updated link to direct to #L9 #682

Merged
merged 1 commit into from
Mar 6, 2020

Conversation

vinayak42
Copy link
Contributor

@vinayak42 vinayak42 commented Oct 16, 2018

@misterdorm The link to /mail/send Helper looked fine. Please provide details as to where it should direct to.

Fixes #633

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

If you have questions, please send an email to SendGrid, or file a GitHub Issue in this repository.

@misterdorm The link to /mail/send Helper looked fine. Please provide details as to where it should direct to.
@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 16, 2018
@codecov
Copy link

codecov bot commented Oct 16, 2018

Codecov Report

Merging #682 into master will decrease coverage by 0.25%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #682      +/-   ##
==========================================
- Coverage   85.03%   84.77%   -0.26%     
==========================================
  Files          35       35              
  Lines        1156     1156              
  Branches      172      172              
==========================================
- Hits          983      980       -3     
  Misses         90       90              
- Partials       83       86       +3
Impacted Files Coverage Δ
sendgrid/helpers/mail/spam_check.py 88.46% <0%> (-7.7%) ⬇️
sendgrid/helpers/inbound/config.py 93.93% <0%> (-3.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cedb4cc...d2224e4. Read the comment docs.

@misterdorm misterdorm added status: work in progress Twilio or the community is in the process of implementing difficulty: easy fix is easy in difficulty and removed status: code review request requesting a community code review or review from Twilio labels Oct 16, 2018
Copy link
Contributor

@misterdorm misterdorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a previous edition of README linked to a different line number. Sorry for the confusion, thanks for this!

@thinkingserious thinkingserious added hacktoberfest type: docs update documentation change not affecting the code status: waiting for feedback waiting for feedback from the submitter and removed status: work in progress Twilio or the community is in the process of implementing labels Oct 23, 2018
@thinkingserious
Copy link
Contributor

Hello @vinayak42,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@thinkingserious
Copy link
Contributor

Hello @vinayak42,

Could you please merge this against our v4 branch? Thank you!

With Best Regards,

Elmer

@vinayak42 vinayak42 changed the base branch from master to v4 October 23, 2018 18:09
@vinayak42
Copy link
Contributor Author

@thinkingserious Changed the branch to sendgrid:v4, anything else to be done?

@misterdorm
Copy link
Contributor

@vinayak42 Looks like you may have merged the v4 branch in, which included everything from master, vs. rebasing your branch against v4. Could you please rebase instead of merging them together? Thanks.

Copy link
Contributor

@misterdorm misterdorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs rebase against v4 branch, instead of merge.

@vinayak42 vinayak42 changed the base branch from v4 to master October 26, 2018 18:17
@vinayak42 vinayak42 changed the base branch from master to v4 October 26, 2018 18:21
@vinayak42 vinayak42 changed the base branch from v4 to master October 26, 2018 18:21
@thinkingserious
Copy link
Contributor

Hello @vinayak42,

Thanks again for the PR!

You have earned 5 out of the 5 points needed to receive glorious SendGrid Hacktoberfest swag.

Please take a moment to checkout this link to find more issues to get you past the required threshold or to simply continue the celebration.

Also, please be sure you have officially registered with us here by November 1, 2018 to qualify.

If you have any questions you can email us at [email protected].

Thank you and Happy Hacktobering!

Team SendGrid

@vinayak42
Copy link
Contributor Author

@thinkingserious @misterdorm Apologies for the inconvenience. I am having some issues about rebasing this to v4. Could you trace the exact steps/commands to do the same in GitHub?

@misterdorm
Copy link
Contributor

@vinayak42 It's probably easiest to start with a new branch, branched from v4, and then merge/apply your commits onto that branch. And then force push to this PR.

@thinkingserious
Copy link
Contributor

Hello @vinayak42,

Do you mind resubmitting this PR, but against the v4 branch?

Thanks!

With Best Regards,

Elmer

@childish-sambino childish-sambino merged commit 9469b24 into sendgrid:master Mar 6, 2020
@childish-sambino childish-sambino changed the title Updated link to direct to #L9 docs: Updated link to direct to #L9 Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: easy fix is easy in difficulty status: waiting for feedback waiting for feedback from the submitter type: docs update documentation change not affecting the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants