-
Notifications
You must be signed in to change notification settings - Fork 714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Updated link to direct to #L9 #682
Conversation
@misterdorm The link to /mail/send Helper looked fine. Please provide details as to where it should direct to.
Codecov Report
@@ Coverage Diff @@
## master #682 +/- ##
==========================================
- Coverage 85.03% 84.77% -0.26%
==========================================
Files 35 35
Lines 1156 1156
Branches 172 172
==========================================
- Hits 983 980 -3
Misses 90 90
- Partials 83 86 +3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a previous edition of README linked to a different line number. Sorry for the confusion, thanks for this!
Hello @vinayak42, |
Hello @vinayak42, Could you please merge this against our v4 branch? Thank you! With Best Regards, Elmer |
@thinkingserious Changed the branch to sendgrid:v4, anything else to be done? |
@vinayak42 Looks like you may have merged the v4 branch in, which included everything from master, vs. rebasing your branch against v4. Could you please rebase instead of merging them together? Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs rebase against v4 branch, instead of merge.
Hello @vinayak42, |
@thinkingserious @misterdorm Apologies for the inconvenience. I am having some issues about rebasing this to v4. Could you trace the exact steps/commands to do the same in GitHub? |
@vinayak42 It's probably easiest to start with a new branch, branched from |
Hello @vinayak42, Do you mind resubmitting this PR, but against the v4 branch? Thanks! With Best Regards, Elmer |
@misterdorm The link to /mail/send Helper looked fine. Please provide details as to where it should direct to.
Fixes #633
Checklist
Short description of what this PR does:
If you have questions, please send an email to SendGrid, or file a GitHub Issue in this repository.